AAI-384: Registration endpoint for SBP#74
Merged
Merged
Conversation
- Introduced SBP registration request schema. - Implemented SBP user registration endpoint with email notification. - Updated platform enums and mappings to include SBP. - Added tests for SBP registration, including validation and error handling.
…ckend into sbp-register
amandazhuyilan
previously approved these changes
Sep 22, 2025
amandazhuyilan
left a comment
amandazhuyilan
left a comment
Contributor
There was a problem hiding this comment.
Looks great - just again nit picking on small stuff...
marius-mather
previously approved these changes
Sep 22, 2025
marius-mather
left a comment
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, just wanted to check whether SBP platform membership should be auto-approved or not.
…nd SBP registration approvals
minh-biocommons
dismissed stale reviews from marius-mather and amandazhuyilan
via
d56f4fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-384: Registration endpoint for SBP
Changes
Checklist