Backend endpoint to list and filter users (to be used by sysadmins)#64
Conversation
|
This is a PR for adding filter functionality to the admin’s GET /users endpoint. I’m not really sure where the platforms and groups/bundles definitions should live, so for now they’re a bit scattered between |
amandazhuyilan
left a comment
There was a problem hiding this comment.
Overall no concerns except for suggestion of the Enum group for BiocommonsGroupEnum :) Thanks for the change.
marius-mather
left a comment
There was a problem hiding this comment.
I've made a few comments about possible changes to the database/refactoring how we store information about groups and platforms - those are up for discussion and don't need to be done in this PR.
But my main comment on this is that I think we should have separate filters for group and platform, rather than trying to have a magic all-purpose filter. That will make it easier to add more filters in future, and also allow combining multiple filters.
marius-mather
left a comment
There was a problem hiding this comment.
Happy to merge this so we have an implementation of the current design - I will do some thinking around some of the refactoring that could make this a bit cleaner.
Description
AAI-290: Back-end endpoint to list and filter users (to be used by sysadmins)
Changes
Checklist