Skip to content

implement is-admin endpoint#58

Merged
minh-biocommons merged 2 commits into
mainfrom
check-admin
Aug 25, 2025
Merged

implement is-admin endpoint#58
minh-biocommons merged 2 commits into
mainfrom
check-admin

Conversation

@minh-biocommons

@minh-biocommons minh-biocommons commented Aug 25, 2025

Copy link
Copy Markdown
Collaborator

Description

AAI-273: Determine if user is admin in aai-backend

Changes

  • Implement is-admin endpoint for the front-end to check if the current user is an admin or not
  • Added tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)

@marius-mather marius-mather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just a couple spots where the tests could potentially be cleaned up a bit.

Comment thread routers/user.py
Comment thread tests/test_user.py Outdated
Comment thread tests/test_user.py Outdated

@marius-mather marius-mather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks!

@minh-biocommons minh-biocommons merged commit 73d846a into main Aug 25, 2025
2 checks passed
@amandazhuyilan amandazhuyilan deleted the check-admin branch November 24, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants