AAI-289 Add a more useful response for registration errors#51
Merged
Conversation
amandazhuyilan
previously approved these changes
Aug 20, 2025
minh-biocommons
previously approved these changes
Aug 20, 2025
d9fa0f9
amandazhuyilan
approved these changes
Aug 21, 2025
amandazhuyilan
left a comment
Contributor
There was a problem hiding this comment.
Looks good - I’ll also try some errors out once this is merged!
Collaborator
Author
|
@amandazhuyilan we still need to update the frontend to use these errors - but they should all come back in a sensible format now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-289: add an error response for registration requests that's easier to use in the frontend. Where possible, the response should specify which fields have errors and individual error messages for them.
Changes
RegistrationErrorResponsethat is returned (with status code 400) for registration errors.RegistrationErrorResponsein registration endpointsChecklist
How to Test Manually (if necessary)
Run
uv run pytest