Skip to content

Implement Biocommons user registration endpoint#50

Merged
minh-biocommons merged 3 commits into
mainfrom
biocommons-registration
Aug 20, 2025
Merged

Implement Biocommons user registration endpoint#50
minh-biocommons merged 3 commits into
mainfrom
biocommons-registration

Conversation

@minh-biocommons

@minh-biocommons minh-biocommons commented Aug 18, 2025

Copy link
Copy Markdown
Collaborator

Description

AAI-287: Add Biocommons account registration back-end endpoint & connect to front-end

Changes

  • Added biocommons_register router for user registration.
  • Created BiocommonsRegistrationRequest schema for registration data validation.
  • Implemented user record creation logic in the database.
  • Added email notification for new user registrations.
  • Updated tests for biocommons user registration functionality.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)

- Added biocommons_register router for user registration.
- Created BiocommonsRegistrationRequest schema for registration data validation.
- Implemented user record creation logic in the database.
- Added email notification for new user registrations.
- Updated tests for biocommons user registration functionality.
@minh-biocommons

Copy link
Copy Markdown
Collaborator Author

Sorry again for some of the automatic style changes, I have the Ruff extension installed, and it re-formats the code on save. This is based on the user database schema image, and it took me a while to go through and understand the document and its implementation from the recent code changes. Please feel free to suggest or request changes if I’ve misunderstood anything.

@marius-mather

Copy link
Copy Markdown
Collaborator

@minh-biocommons thanks, I'll review shortly. Automatic style fixes are great! They just need to be configured so that everyone working on the project is using the same settings, that way the code you actually changed gets cleaned up but not other unrelated code. I think we've got that all set up here already so we're getting the kinds of changes we want.

@marius-mather marius-mather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but I think we need to discuss how bundles are defined and managed within the team.

Comment thread routers/biocommons_register.py Outdated
Comment thread routers/biocommons_register.py Outdated
Comment thread routers/biocommons_register.py Outdated
Comment thread tests/test_biocommons_register.py Outdated
Comment thread tests/test_biocommons_register.py
@amandazhuyilan

Copy link
Copy Markdown
Contributor

As per in person discussion with @minh-biocommons - we agreed to following the linting style set in this repo, I recommend that this PR only contain changed related to the user registration endpoint and not linting.

FYI - linting can be applied through pre-commit (refer to README for installation instructions), or manually via uv run -- ruff check . --fix (also mentioned in README)

@minh-biocommons

Copy link
Copy Markdown
Collaborator Author

I can't seem to revert the existing auto-format even after running uv run -- ruff check . --fix and pre-commit run --all-files. I've uninstalled the extension in my VSCode and will just be using the 2 commands form the README from now on.

@marius-mather marius-mather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, I think we just need a final decision on whether the platforms are auto-approved.

Comment thread routers/biocommons_register.py Outdated
Comment thread routers/biocommons_register.py
Comment thread routers/biocommons_register.py Outdated

@marius-mather marius-mather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks!

@minh-biocommons minh-biocommons merged commit 37a74d3 into main Aug 20, 2025
2 checks passed
@amandazhuyilan amandazhuyilan deleted the biocommons-registration branch June 19, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants