Implement Biocommons user registration endpoint#50
Conversation
- Added biocommons_register router for user registration. - Created BiocommonsRegistrationRequest schema for registration data validation. - Implemented user record creation logic in the database. - Added email notification for new user registrations. - Updated tests for biocommons user registration functionality.
|
Sorry again for some of the automatic style changes, I have the Ruff extension installed, and it re-formats the code on save. This is based on the user database schema image, and it took me a while to go through and understand the document and its implementation from the recent code changes. Please feel free to suggest or request changes if I’ve misunderstood anything. |
|
@minh-biocommons thanks, I'll review shortly. Automatic style fixes are great! They just need to be configured so that everyone working on the project is using the same settings, that way the code you actually changed gets cleaned up but not other unrelated code. I think we've got that all set up here already so we're getting the kinds of changes we want. |
marius-mather
left a comment
There was a problem hiding this comment.
Looks good so far but I think we need to discuss how bundles are defined and managed within the team.
|
As per in person discussion with @minh-biocommons - we agreed to following the linting style set in this repo, I recommend that this PR only contain changed related to the user registration endpoint and not linting. FYI - linting can be applied through |
… in user registration
|
I can't seem to revert the existing auto-format even after running |
marius-mather
left a comment
There was a problem hiding this comment.
Looking pretty good, I think we just need a final decision on whether the platforms are auto-approved.
…adjust tests accordingly
marius-mather
left a comment
There was a problem hiding this comment.
Looking good now, thanks!
Description
AAI-287: Add Biocommons account registration back-end endpoint & connect to front-end
Changes
Checklist