User Endpoints Implementation#4
Merged
Merged
Conversation
and maintainability
…larity and coverage
… dependencies in tests
…ation and disable network calls in tests
…arity and remove network call disabling in tests
marius-mather
requested changes
May 9, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looking good! I think we should have a couple more schemas for our data so we always know what we expect (and any differences from that expectation show up clearly).
Great set of tests but I think they could be made a little bit clearer/easier to follow.
…ios and error handling
marius-mather
previously approved these changes
May 13, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
This is looking great now, thanks! I updated the tests to use automatically generated data for the Auth0User where possible - hopefully now you can start to see that all the Pydantic model stuff I keep asking for can make things easier down the track rather than just being extra work!
marius-mather
approved these changes
May 13, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Approving again after a minor change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-181: Define and Create Route Definitions for User Endpoints
Changes
Checklist
How to Test Manually (if necessary)
For manual testing, follow these steps: