Skip to content

AAI-119 fix alembic not handling enum in migrations#39

Merged
marius-mather merged 5 commits into
mainfrom
db-migrations
Jul 3, 2025
Merged

AAI-119 fix alembic not handling enum in migrations#39
marius-mather merged 5 commits into
mainfrom
db-migrations

Conversation

@marius-mather

@marius-mather marius-mather commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

Description

AAI-119: reworking migrations: alembic is a bit finicky about Enum types, so easier to reset the migrations and start again than fix them. Also adding a GitHub Action to check migrations so we don't get caught by this again

Changes

  • Reset migrations and generate a new one - Enums work automatically when creating a new table
  • Add GitHub Action to check migrations so we don't break them

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)

How to Test Manually (if necessary)

Run uv run python generate_migrations.py --check

@amandazhuyilan amandazhuyilan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to complain :)

@marius-mather marius-mather merged commit 207df45 into main Jul 3, 2025
2 checks passed
@amandazhuyilan amandazhuyilan deleted the db-migrations branch June 19, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants