Email approvers when we have a new user request to join orgs#33
Merged
Conversation
marius-mather
requested changes
Jun 29, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall but I think the actual email sending should occur in a separate function, and ideally a background task, rather than as part of the main registration function.
825062f to
093e1d3
Compare
marius-mather
requested changes
Jul 1, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looking really good overall - just one suggestion re: making sure we move all the email-related work into the background task.
marius-mather
approved these changes
Jul 1, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-127: Email approvers when we have a new user request to join orgs
Changes
-Send email to approvers on new BPA user registration
EmailServiceusing AWS SESAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYadded as Github action secretsChecklist
How to Test Manually (if necessary)
All unit tests shall pass.
Sample email here:
