add more data for resources#30
Merged
Merged
Conversation
marius-mather
requested changes
Jun 12, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - just one question about whether we should have user emails in the updated_by field or that should only reflect admins/people who are authorized to do approvals.
marius-mather
requested changes
Jun 12, 2025
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, just one tiny change to suggest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-221: Add
last_updatedandupdated_byinResourcemodels.Changes
updated_byfield toResourcemodels.approve_resourceto requireupdated_by.updated_bypresence.Checklist
How to Test Manually (if necessary)
All tests shall pass.