Skip to content

feat: add endpoint and email for deleting accounts with incorrect email (AAI-829)#271

Merged
marius-mather merged 21 commits into
mainfrom
delete-incorrect-email
May 22, 2026
Merged

feat: add endpoint and email for deleting accounts with incorrect email (AAI-829)#271
marius-mather merged 21 commits into
mainfrom
delete-incorrect-email

Conversation

@marius-mather

@marius-mather marius-mather commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Description

AAI-829: add an endpoint to delete accounts with incorrect email - and notify users.

Changes

  • Switch to Jinja2 templates for emails - less HTML in our code, and allows tighter control of escaping and template variables
  • Add template for notifying users about incorrect emails
  • Admin endpoint: POST /users/{user_id}/delete_invalid_email
  • Unit tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

Run uv run pytest

Example email:

Screenshot 2026-05-22 at 12 54 18 pm

@minh-biocommons minh-biocommons left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, good separation of concerns!

@marius-mather marius-mather merged commit 320a0a7 into main May 22, 2026
5 checks passed
@marius-mather marius-mather deleted the delete-incorrect-email branch May 22, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants