Skip to content

feat: add TSI bundle rejection email#252

Merged
amandazhuyilan merged 2 commits into
mainfrom
AAI-813-add-TSI-bundle-rejection-email
Apr 17, 2026
Merged

feat: add TSI bundle rejection email#252
amandazhuyilan merged 2 commits into
mainfrom
AAI-813-add-TSI-bundle-rejection-email

Conversation

@amandazhuyilan

@amandazhuyilan amandazhuyilan commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Description

AAI-813: Add TSI bundle rejection email

Also added in email template: https://biocloud.atlassian.net/wiki/spaces/AAAI/pages/534478851/BioCommons+Access+email+templates+content#TSI-Bundle-Rejection-Email-%5BinlineCard%5D

Changes

  • Adds compose_group_membership_rejected_email() email template in biocommons/emails.py with TSI-specific content explaining consortium membership, open-access alternatives, and contact details
  • Updates the reject_group_membership endpoint in routers/admin.py to enqueue a rejection email to the requester on rejection (mirrors the existing approve flow)
  • Updates existing rejection test to include mock_auth0_client, and adds a new test asserting the email is queued on rejection

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

uv run pytest

UI - Sample TSI bundle rejection email

Screenshot 2026-04-17 at 11 15 14 am

@amandazhuyilan amandazhuyilan force-pushed the AAI-813-add-TSI-bundle-rejection-email branch from fadd58e to 0b51128 Compare April 17, 2026 01:55
@amandazhuyilan amandazhuyilan merged commit f834154 into main Apr 17, 2026
5 checks passed
@amandazhuyilan amandazhuyilan deleted the AAI-813-add-TSI-bundle-rejection-email branch April 17, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants