refactor: better query for user counts#248
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors admin user-counting logic to run a dedicated COUNT() query instead of selecting full user rows, and adds a regression test to ensure the current admin user is excluded from pagination totals.
Changes:
- Reworked
UserQueryParams.get_count()to issue a directSELECT COUNT(user_id)with existing permission/filter conditions. - Added an admin API test covering
/admin/users/pagestotals with exclusion of the current admin user across pagination and approval-status filters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| routers/admin.py | Updates UserQueryParams.get_count() to use a direct COUNT() statement with existing permission/filter predicates. |
| tests/admin_api/test_admin.py | Adds regression coverage for /admin/users/pages to ensure the current admin user is excluded from counts. |
amandazhuyilan
approved these changes
Apr 1, 2026
amandazhuyilan
left a comment
Contributor
There was a problem hiding this comment.
Nice logic change! Hopes this makes the query faster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rework functions that count users (based on query params) - use dedicated query logic that just counts user IDs instead of selecting the whole user table.
Changes
UserQueryParams.get_count()Checklist
How to Test Manually (if necessary)
Run
uv run pytest