AAI-236 Unify schemas for user data and metadata#23
Conversation
…er session vs. user in Auth0 DB
amandazhuyilan
left a comment
There was a problem hiding this comment.
Overall looks great except for usual nik pik on docstrings - thanks for making this change!
I was wondering what is the rationale behind the renaming User class to SessionUser?
We have multiple different "User" objects so wanted to try and clarify what this one represented. Maybe there's a better name than |
Co-authored-by: Amanda Zhu <amandazhuyilan@gmail.com>
amandazhuyilan
left a comment
There was a problem hiding this comment.
Looks good to me! Lets ship it 🚢
|
Not quite ready to ship sorry! Needs a bit of testing against our actual Auth0 instance (found some errors where if app or user metadata weren't defined, the data would fail validation). I'll request approval when it's good to go |
|
OK @amandazhuyilan should be good to go now. I'll do a test registration once it's deployed to double-check everything works as expected |
amandazhuyilan
left a comment
There was a problem hiding this comment.
Approve assuming double testing passed @marius-mather
Description
AAI-236: unify/combine any schemas we have for user data sent and received from Auth0, so we don't end up with incompatible schemas defined in different places
Changes
biocommonsschema module with schemas for our core user dataChecklist
How to Test Manually (if necessary)
Run
uv run pytest