AAI-182 refactor and clean up user/role checking to enable admin endpoints#19
Merged
Conversation
… by user_is_admin)
Contributor
|
Overall looks great - just a nick pick on linting... |
amandazhuyilan
previously approved these changes
May 25, 2025
amandazhuyilan
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-182: I started on implementing admin endpoints, but realised we needed a bit of a refactor of how we check users/roles. This PR contains an initial admin endpoint to show the approach, but also refactors our existing user checks.
Changes
user_is_admincheck that we can apply to all admin routes/admin/usersendpoint to demonstrate a route that requires adminChecklist
How to Test Manually (if necessary)
Run
uv run pytest