Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions routers/bpa_register.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,11 @@ async def register_bpa_user(
response = await client.post(
url, headers=headers, json=user_data.model_dump()
)

if response.status_code == 409:
raise HTTPException(
status_code=409,
detail="User with this email or username already exists",
)

if response.status_code != 201:
raise HTTPException(
status_code=400, detail=f"Failed to create user: {response.text}"
status_code=400,
detail=f"Registration failed: {response.json()['message']}",
)

return {"message": "User registered successfully", "user": response.json()}

except HTTPException:
Expand Down
11 changes: 7 additions & 4 deletions tests/test_bpa_register.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,16 @@ def test_registration_duplicate_user(
"""Test registration with duplicate user"""
mock_response = MagicMock()
mock_response.status_code = 409
mock_response.json.return_value = {"message": "User already exists"}

mocker.patch("httpx.AsyncClient.post", return_value=mock_response)

response = client_with_settings_override.post(
"/bpa/register", json=valid_registration_data
)

assert response.status_code == 409
assert "already exists" in response.json()["detail"]
assert response.status_code == 400
assert response.json()["detail"] == "Registration failed: User already exists"


def test_registration_auth0_error(
Expand All @@ -87,15 +89,16 @@ def test_registration_auth0_error(
"""Test registration with Auth0 API error"""
mock_response = MagicMock()
mock_response.status_code = 400
mock_response.text = "Invalid request"
mock_response.json.return_value = {"message": "Invalid request"}

mocker.patch("httpx.AsyncClient.post", return_value=mock_response)

response = client_with_settings_override.post(
"/bpa/register", json=valid_registration_data
)

assert response.status_code == 400
assert "Failed to create user" in response.json()["detail"]
assert response.json()["detail"] == "Registration failed: Invalid request"


def test_registration_with_invalid_organization(
Expand Down