Skip to content

Fix signup loading after account creation#14481

Closed
raymondjacobson wants to merge 2 commits into
mainfrom
codex/fix-signup-loading-record-ip
Closed

Fix signup loading after account creation#14481
raymondjacobson wants to merge 2 commits into
mainfrom
codex/fix-signup-loading-record-ip

Conversation

@raymondjacobson

@raymondjacobson raymondjacobson commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix the signup loading page so it finishes once the current account query reports an indexed, complete account.
  • Fix identity-service auth middleware to backfill provisional users through the current SDK shape: audiusSdk.users.getUserAccount(...), with a legacy full.users fallback and a 3s timeout.
  • Keep /record_ip from 500ing if a request arrives before identity has a handle.

Root cause

  • The signup client writes the handle in the create-user EntityManager metadata and API can later return it from /v1/users/account/:wallet.
  • Identity /user only creates the provisional row. The intended modern path is auth middleware backfilling blockchainUserId and handle from getUserAccount.
  • Identity now loads @audius/sdk via sdk(...), which exposes users at the top level. The middleware still called audiusSdk.full.users, so the backfill failed and identity rows stayed null.

Testing

  • node --check packages/identity-service/src/authMiddleware.js
  • node --check packages/identity-service/src/routes/idSignals.js
  • git diff --check

Note: the normal package test runner was not available in this local worktree because npm, pnpm, yarn, and corepack are absent.

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 66c0602

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant