Fix signup loading after account creation#14481
Closed
raymondjacobson wants to merge 2 commits into
Closed
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audiusSdk.users.getUserAccount(...), with a legacyfull.usersfallback and a 3s timeout./record_ipfrom 500ing if a request arrives before identity has a handle.Root cause
/v1/users/account/:wallet./useronly creates the provisional row. The intended modern path is auth middleware backfillingblockchainUserIdandhandlefromgetUserAccount.@audius/sdkviasdk(...), which exposesusersat the top level. The middleware still calledaudiusSdk.full.users, so the backfill failed and identity rows stayed null.Testing
node --check packages/identity-service/src/authMiddleware.jsnode --check packages/identity-service/src/routes/idSignals.jsgit diff --checkNote: the normal package test runner was not available in this local worktree because
npm,pnpm,yarn, andcorepackare absent.