Repository navigation
feat: add interactive birth-chart homepage hero - #56
Merged
Merged
Conversation
|
Review complete. Run log Scope: full (base-merged-in); commit: |
…irth-chart-hero-20261117
There was a problem hiding this comment.
Full-scope review of the diff: no correctness or security issues found. I checked the Wheel API refactor against ExplorerChart, the visible-quarter math, the info-card positioning, and the removal of review mode (no dangling references to review.sh or runStack). I did not run the test suite.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the static homepage illustration with a real sample natal chart. Visible glyphs and aspect lines open CMS-backed information cards; keyboard activation keeps focus, Escape/outside clicks dismiss cards, and desktop/mobile layouts clip the oversized wheel to the intended quarter.
Imported from the birth-chart hero original and full returned archives. Reconstructed source:
61068cee0c3cacaba4e3cbab171d0eaab96bf470(492/494 original files match exactly; only README and disposable review runner differ), accepted by the user. Base:34bbf71on main. The chart import reconciled without conflicts. After removing the obsolete review runner and its README reference, the final diff contains 5 additions, 7 modifications and 1 deletion, with no relocations.Reuse the released CMS
landing.sample.labelinstead of the archive's unreleasedlanding.chart.label. Exclude the disposable review runner, seed-contract bootstrap/helpers, bootstrap README and Playwright config edits, generated output, local databases, loose CMS seed and supplied screenshots. Delete the repository's olderscripts/review.shand remove its README reference, as requested. The container-only CMS workarounds remain excluded. No dependency changes, migrations or direct deployments.Evidence
After: Local desktop (1440×900) and mobile (390×844) screenshots reviewed, including Jupiter cards, against the supplied reference layout.
scripts/review.sh, seed-contract bootstrap or snapshot-only Playwright mode remain in application/development files.Merge Danger
Door: two-way
Revert restores the previous homepage and wheel event interface.
Blast Radius: chart
Shared wheel event wiring affects the homepage and explorer; full browser coverage passed locally. Hosted preview and CI results are separate from local validation.