Skip to content

feat: add interactive birth-chart homepage hero - #56

Merged
jacksteamdev merged 4 commits into
mainfrom
import/birth-chart-hero-20261117
Nov 18, 2026
Merged

jacksteamdev merged 4 commits into
mainfrom
import/birth-chart-hero-20261117

Conversation

@jacksteamdev

@jacksteamdev jacksteamdev commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Replace the static homepage illustration with a real sample natal chart. Visible glyphs and aspect lines open CMS-backed information cards; keyboard activation keeps focus, Escape/outside clicks dismiss cards, and desktop/mobile layouts clip the oversized wheel to the intended quarter.

Homepage → Wheel → glyph/aspect event → information card
Explorer → Wheel → same events → existing details/picker

Imported from the birth-chart hero original and full returned archives. Reconstructed source: 61068cee0c3cacaba4e3cbab171d0eaab96bf470 (492/494 original files match exactly; only README and disposable review runner differ), accepted by the user. Base: 34bbf71 on main. The chart import reconciled without conflicts. After removing the obsolete review runner and its README reference, the final diff contains 5 additions, 7 modifications and 1 deletion, with no relocations.

Reuse the released CMS landing.sample.label instead of the archive's unreleased landing.chart.label. Exclude the disposable review runner, seed-contract bootstrap/helpers, bootstrap README and Playwright config edits, generated output, local databases, loose CMS seed and supplied screenshots. Delete the repository's older scripts/review.sh and remove its README reference, as requested. The container-only CMS workarounds remain excluded. No dependency changes, migrations or direct deployments.

Evidence

  • Before: Homepage used a static illustrative SVG.
    After: Local desktop (1440×900) and mobile (390×844) screenshots reviewed, including Jupiter cards, against the supplied reference layout.
  • 71 browser tests passed across default, pseudo-locale and CMS-down projects using an isolated CMS checkout.
  • 17 Node tests and 40 Bun verification tests passed.
  • Svelte/TypeScript checks, lint, formatting, full build, and staging/alpha Worker dry runs passed.
  • Regenerating the sample chart produces identical committed data.
  • Follow-up runner deletion and README cleanup: formatting and diff checks passed; no references to scripts/review.sh, seed-contract bootstrap or snapshot-only Playwright mode remain in application/development files.
  • Complete import/execution-path review and staged Gitleaks scan with external default configuration, allow suppression disabled and full redaction passed. No archived code ran before review.

Merge Danger

Door: two-way

Revert restores the previous homepage and wheel event interface.

Blast Radius: chart

Shared wheel event wiring affects the homepage and explorer; full browser coverage passed locally. Hosted preview and CI results are separate from local validation.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff (homepage interactive wheel, Wheel event refactor, sample chart generator, visibility helper, tests). No correctness or security issues found.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Review complete. Run log

Scope: full (base-merged-in); commit: 22a748289105ed3149e55b3847fc33364b4bec55.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cleanup note: removing scripts/review.sh leaves its review-mode plumbing in scripts/dev-stack.mjs with no caller. No correctness or security issues found otherwise.

Comment thread README.md Resolved
@github-actions
github-actions Bot temporarily deployed to pr-56 November 18, 2026 20:47 Destroyed

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental review of 4dfa982..5a96db3: no issues found. The review-mode removal is clean, with no leftover references to runStack exports or the REVIEW_* env vars, and the port validation is still correct.

@github-actions
github-actions Bot temporarily deployed to pr-56 November 18, 2026 20:48 Destroyed

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full-scope review of the diff: no correctness or security issues found. I checked the Wheel API refactor against ExplorerChart, the visible-quarter math, the info-card positioning, and the removal of review mode (no dangling references to review.sh or runStack). I did not run the test suite.

@github-actions
github-actions Bot temporarily deployed to pr-56 November 18, 2026 20:50 Destroyed
@jacksteamdev
jacksteamdev merged commit 2285533 into main Nov 18, 2026
6 of 8 checks passed

This branch was successfully deployed

No deployments
pr-56 — 22a74828 Deployed Nov 18, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant