Repository navigation
ci: run Rust tests on the organization self-hosted runner - #102
DJAscendance wants to merge 1 commit into
Conversation
MiniMax-M3.1-Flash QAFindings1. High — Same-repository PRs still execute arbitrary code on the self-hosted runnerLocation: github.event.pull_request.head.repo.full_name == github.repositoryThis condition only distinguishes forks from branches in the upstream repository. It does not establish that the code is trusted. For example:
The workflow comment says that “untrusted code never reaches the self-hosted machine,” but the current expression does not guarantee that. Either:
At minimum, exclude Dependabot and other untrusted actors explicitly rather than relying solely on the fork check. 2. Medium —
|
Moves
rust-tests.ymlfrom GitHub-hostedubuntu-24.04to the org runnergh-runner-ascendance3d([self-hosted, Linux, X64]).ubuntu-24.04, so untrusted code never reaches the self-hosted machine (same pattern as X_ITE_R).CM_RUNNER_LABELSoverrides the labels (set it to"ubuntu-24.04"to force hosted).