Skip to content

Pull in some missing commits from /lb/localnot#966

Merged
JamesPiechota merged 6 commits into
masterfrom
jp/post-chunk-20260318
Mar 23, 2026
Merged

Pull in some missing commits from /lb/localnot#966
JamesPiechota merged 6 commits into
masterfrom
jp/post-chunk-20260318

Conversation

@JamesPiechota

@JamesPiechota JamesPiechota commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Main purpose of this PR is to pull in some commits we missed when cherry-picking from lb/localnet.

I also started adding some tests, but since they aren't quite done yet, commenting them out so I can get the cherry-picks merged

@JamesPiechota JamesPiechota force-pushed the jp/post-chunk-20260318 branch from 252e90d to 20c1a68 Compare March 21, 2026 01:44
previous implementation wouldn't always trigger a call
to POST /data_roots
Also adds a new test case that currently fails: calling GET /chunk after a successful POST /chunk

Future commit will hopefully fix this test case
Handle more than just no_proc and shutdown, normal

but keep logic to only retry it once
@JamesPiechota JamesPiechota force-pushed the jp/post-chunk-20260318 branch from 20c1a68 to cec557a Compare March 23, 2026 22:57
@JamesPiechota JamesPiechota changed the title WIP Pull in some missing commits from /lb/localnot Mar 23, 2026
@JamesPiechota JamesPiechota marked this pull request as ready for review March 23, 2026 22:59
@JamesPiechota JamesPiechota merged commit d3bb5e3 into master Mar 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant