Pull in some missing commits from /lb/localnot#966
Merged
Conversation
252e90d to
20c1a68
Compare
previous implementation wouldn't always trigger a call to POST /data_roots
Also adds a new test case that currently fails: calling GET /chunk after a successful POST /chunk Future commit will hopefully fix this test case
Handle more than just no_proc and shutdown, normal but keep logic to only retry it once
20c1a68 to
cec557a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main purpose of this PR is to pull in some commits we missed when cherry-picking from lb/localnet.
I also started adding some tests, but since they aren't quite done yet, commenting them out so I can get the cherry-picks merged