Skip to content

fix: remove noisy cloud provider warning on chat send - #538

Open
roian6 wants to merge 1 commit into
Arvo-AI:mainfrom
roian6:bugfix/remove-chat-provider-warning
Open

roian6 wants to merge 1 commit into
Arvo-AI:mainfrom
roian6:bugfix/remove-chat-provider-warning

Conversation

@roian6

@roian6 roian6 commented Jun 19, 2026

Copy link
Copy Markdown

Summary

  • Remove the repeated “No cloud provider selected” toast from the general chat send flow.
  • Drop the connected-accounts lookup that was only used to decide whether to show that warning.
  • Keep normal message sending, provider preferences, and existing error toasts unchanged.

Context

Issue #518 reports that the provider warning fires on every message send. The issue discussion points toward deleting this notification rather than changing connected-account key matching, so this keeps the fix limited to the chat send warning path.

Testing

  • python3 regression check: confirmed the warning string, anyProviderConnected, and useConnectedAccounts are absent from client/src/app/chat/components/useChatSendHandlers.ts
  • git diff --check
  • npm run build

Attempted but currently blocked by existing baseline/tooling issues:

  • ⚠️ npm run lint fails with The requested module 'minimatch' does not provide an export named 'default'
  • ⚠️ npx tsc --noEmit fails on existing Next/type errors, including generated .next/types route context errors and pre-existing nullability errors in useChatSendHandlers.ts

Fixes #518

Summary by CodeRabbit

  • Refactor
    • Simplified provider handling in chat messaging. Provider warnings have been consolidated, and logic has been streamlined for improved efficiency.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e03afb02-6ebf-4444-9921-9422e50cf1a5

📥 Commits

Reviewing files that changed from the base of the PR and between 00d9699 and e9682ff.

📒 Files selected for processing (1)
  • client/src/app/chat/components/useChatSendHandlers.ts

Walkthrough

Removes the useConnectedAccounts hook, its derived anyProviderConnected/getConnectedProviders values, and the conditional toast warning from useChatSendHandlers. The initiateSend callback now calls sendMessage directly without a provider-presence guard.

Remove provider-connected toast from send flow

Layer / File(s) Summary
Remove useConnectedAccounts check and toast from initiateSend
client/src/app/chat/components/useChatSendHandlers.ts
Deletes the useConnectedAccounts import, its hook destructuring, and the anyProviderConnected/getConnectedProviders derived values. Simplifies initiateSend to call sendMessage directly, removing the branch that showed a "No cloud provider connected" toast.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hop hop, no more toast today,
The warning was firing the wrong way!
No provider check on every send,
The noisy alert has met its end.
Clean and quiet, the messages flow —
A happy rabbit watching code glow! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: removing the noisy cloud provider warning on chat send, which aligns with the main objective.
Linked Issues check ✅ Passed The PR successfully addresses issue #518 by removing the incorrectly-firing provider warning toast and eliminating the useConnectedAccounts hook that exclusively triggered it.
Out of Scope Changes check ✅ Passed The changes are focused and in-scope: only the useChatSendHandlers.ts file was modified to remove warning-related logic and imports.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@beng360 beng360 added the external contributor PR from an external contributor label Jun 20, 2026
@beng360

beng360 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Hi! Thanks for your contribution. Before we can merge this, we need you to sign our Contributor License Agreement (CLA) for legal purposes. This is a one-time requirement for external contributors — it ensures that contributions are properly licensed and that both parties are protected.

I'll send the document separately. Once signed, we're good to go on this and any future PRs.

@roian6

roian6 commented Jun 22, 2026

Copy link
Copy Markdown
Author

Hi @beng360, happy to sign the CLA.

I checked the repository docs, contribution guide, and Aurora docs, but I couldn't find a public CLA signing link. I also don't think I've received the separate document yet.

Could you resend it or point me to the correct signing link/email flow? Thanks!

@roian6

roian6 commented Jul 12, 2026

Copy link
Copy Markdown
Author

Hi @beng360 — following up on the CLA step. I'm still happy to sign, but I haven't received the separate document and couldn't find a public signing link. Could you resend the document or share the signing URL/process when convenient? The PR remains ready on my side. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external contributor PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: 'No cloud provider connected' toast fires incorrectly on every message send

2 participants