Port Arroyo SQL extensions to sqlparser 0.62 - #2
Closed
QnJ1c2kNCg wants to merge 4 commits into
Closed
QnJ1c2kNCg wants to merge 4 commits into
QnJ1c2kNCg wants to merge 4 commits into
Conversation
Preserve PostgreSQL-style expressions and Arroyo capabilities using dialect hooks instead of additional concrete dialect checks. Keep Arroyo type identity so generated columns do not require STORED; cover this behavior with a PostgreSQL comparison regression. Ported-from: 32b9bbe Ported-from: 83877ac
Preserve optional watermark expressions, constraint spans and formatting. Gate the syntax with a dialect capability, enabled for Arroyo and Generic; cover missing syntax, named constraints and PostgreSQL rejection. Ported-from: 2279ac9
Retain the metadata key and its source span, with a capability gate checked before consuming tokens. Cover escaped keys, round trips, malformed input and rejection by PostgreSQL. Ported-from: 8c1c36b
Retain the arroyo_partitions AST field and builder conversions for Iceberg transforms and identity partitions. Keep the existing clause position after table options, preserving upstream Hive partition column parsing. Include source spans and regression tests for round trips, builder conversions, dialect boundaries and malformed clauses. Ported-from: 7086ac7
QnJ1c2kNCg
force-pushed
the
broy/sqlparser-0.62-port
branch
from
September 14, 2026 22:53
7265c48 to
887b4ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparser 0.62: review guide
PR:
broy/sqlparser-0.62-port->0.62.0/arroyo. Preserve the four commits. These are adapted ports, not unchanged cherry-picks; each hasPorted-fromtrailers. Review the old behavior against the new implementation:9848a90STORED. Updated dialect APIs; delegating precedence and replacing concrete dialect checks with capability hooks are deliberate restructuring.40f5172WATERMARK FOR column [AS expr]. Required: adapt to the relocated constraint AST. Deliberate: capability gate instead of concrete dialect checks.8a288427265c48Capability hooks follow upstream contributor guidelines; they are not all required by the version upgrade. Regression tests are in tests/sqlparser_arroyo.rs: expressions/
STORED, watermarks, metadata, connector/Hive partitions, round-trips, and rejection cases.