[MC-465] Guard manual cognate partitions#658
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MC Task: MC-465 — Cognate-partition integrity guard / Lane MC-465-A
Summary
find_cognate_partition_violations()for reusable manual cognate partition validation./api/enrichmentswrites after the final deep merge when any speaker appears in multiple manual cognate groups for the same concept.manual_overrides.cognate_setscannot be re-persisted during auto recompute.Validation
PYTHONPATH=python python3 -m pytest python/test_compare_enrichments_manual_overrides.py::test_post_enrichments_rejects_duplicate_manual_cognate_membership_after_merge -qinitially failed withDID NOT RAISE <class 'server.ApiError'>.PYTHONPATH=python python3 -m pytest python/test_compare_enrichments_manual_overrides.py::test_post_enrichments_rejects_duplicate_manual_cognate_membership_after_merge -q->1 passed, 1 warning in 0.06s.PYTHONPATH=python python3 -m pytest python/test_compare_enrichments_manual_overrides.py -q->10 passed, 1 warning in 0.10s.PYTHONPATH=python python3 -m pytest python/ -q -k 'not test_ortho_section_defaults_cascade_guard and not test_ortho_explicit_override_beats_defaults'->1927 passed, 6 skipped, 2 deselected, 1 warning, 3 subtests passed in 37.14s.PYTHONPATH=python python3 -m pytest python/ -q->1929 passed, 6 skipped, 1 warning, 3 subtests passed in 29.39s.uvx ruff check python/ --select E9,F63,F7,F82->All checks passed!.git diff --check-> clean.Notes