Skip to content

feat: add custom metadata support#663

Merged
Archmonger merged 22 commits into
Archmonger:masterfrom
matmair:feat-add-custom-metadata-support
Feb 8, 2026
Merged

feat: add custom metadata support#663
Archmonger merged 22 commits into
Archmonger:masterfrom
matmair:feat-add-custom-metadata-support

Conversation

@matmair

@matmair matmair commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Description

Implementation of the feature discussed in #660
This adds 2 settings and control flows that allow the addition and validation of custom data to the metadata file. This way it is easy to ensure the environment your restore in matches the condition needed for a restore.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@matmair matmair marked this pull request as draft January 15, 2026 18:07
@matmair

matmair commented Jan 15, 2026

Copy link
Copy Markdown
Contributor Author

@Archmonger this would be ready for a first review; is this in general to this projects standards, and what should I change / adapt?

@matmair matmair marked this pull request as ready for review January 15, 2026 22:33
@matmair

matmair commented Jan 25, 2026

Copy link
Copy Markdown
Contributor Author

@Archmonger anything you want to see added/removed here?

Comment thread docs/src/configuration.md Outdated
Comment thread dbbackup/settings.py Outdated
Comment thread dbbackup/management/commands/dbbackup.py Outdated
Comment thread dbbackup/management/commands/dbrestore.py Outdated

@Archmonger Archmonger left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code needs to be formatted via hatch fmt dbbackup/

Can be merged after addressing these remaining comments.

Comment thread dbbackup/utils.py Outdated
Comment thread docs/src/configuration.md
Comment thread dbbackup/utils.py Outdated
@matmair

matmair commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

I think all comments should be addressed now; sorry about missing the formatting in contribution, I did not find a way to get hatch run lint:format working

@Archmonger

Archmonger commented Jan 26, 2026

Copy link
Copy Markdown
Owner

Apologies for that. This repo does not have a hatch run lint:format command. That seems to be a copy-paste error from another one of my repo's contributing.md.

All Python linting for dbbackup is performed via hatch fmt <directory>.

I'll review/fix the contributing docs in a follow up PR.

…w setter to return None, `_VALIDATOR` is a "secondary" validator, ensure user cannot manipulate original metadata.
@Archmonger Archmonger force-pushed the feat-add-custom-metadata-support branch from c3365d4 to c63cb04 Compare February 8, 2026 21:37
@Archmonger Archmonger merged commit bb527a2 into Archmonger:master Feb 8, 2026
19 checks passed
@matmair matmair deleted the feat-add-custom-metadata-support branch February 8, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants