Repository navigation
ci: trust the scratch Homebrew tap before fetching from it - #224
Merged
Merged
Conversation
Homebrew 7 refuses to load a formula from a tap that has not been
trusted ("Refusing to load formula ... from untrusted tap"), which
fails the Homebrew formula job on every PR.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
ArchDev is watching this pull request. State: settled (cycle 1 of 1 for head 3baa11b).
Paused by the |
calvin-archastro
added a commit
that referenced
this pull request
Oct 30, 2026
deferred_tests_decline_unlinked_current_executable copied its own binary
and exec'd the copy. A test thread that forks while the copy's write
descriptor is open hands that descriptor to its child, and exec of a
file open for writing fails with ETXTBSY ("Text file busy"), as CI saw
on #224. A hard link is never opened for writing; it lives beside the
binary because hard links cannot cross filesystems.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
calvin-archastro
added a commit
that referenced
this pull request
Oct 30, 2026
deferred_tests_decline_unlinked_current_executable copied its own binary
and exec'd the copy. A test thread that forks while the copy's write
descriptor is open hands that descriptor to its child, and exec of a
file open for writing fails with ETXTBSY ("Text file busy"), as CI saw
on #224. A hard link is never opened for writing; it lives beside the
binary because hard links cannot cross filesystems.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
The Homebrew formula job fails on every PR (#219, #222, #223):
Refusing to load formula aster-ci/public-release/aster from untrusted tap aster-ci/public-release.brew tap-new, renders the formula into it, then runsbrew fetch.What changed
brew tap-new, the job runsbrew trust --tap aster-ci/public-release.brew commandslistingtrust, so runners on older Homebrew still work.Scope / Risk / User impact
CI workflow only; low risk. The tap is created by the same job, so trusting it grants nothing external. No user impact.
Testing
brew trust --tapon a scratchtap-newtap works locally (Homebrew 7.0.11).🤖 Generated with Claude Code