Repository navigation
Ask before installing global or project-local ArchDev hooks - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The installers currently bypass the CLI's placement question when run outside Git, without Node.js, or without a terminal: they pass
--scope userautomatically. That can install machine-wide hooks without a placement decision.--yesalone no longer chooses global scope.Verification
--yes, explicit-scope and interrupted-prompt cases.Compatibility and rollout
Unattended callers that install hooks must now pass
--scope useror--scope repository(PowerShell:-Scope).--skip-setup/-SkipSetupremains available for CLI-only installation. The release smoke callers have a separate companion update and should be updated before this installer change is deployed. No rollout is claimed by this PR.