Retain directory structure in Visual Studio projects#77
Merged
Conversation
Add a source_group(TREE) call near the end of the CMakeLists.txt template so Visual Studio filter folders mirror the on-disk directory structure across all targets (static library, test runner, and pybind module). Single call at directory scope handles all build configurations because source_group is registered per-file regardless of which target uses the file. Variables are unquoted so empty ones disappear instead of expanding to literal empty-string filenames (which would fail the TREE-root check). New test locks in the unquoted shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Wrap jinja's UndefinedError with a "Missing field in build.toml: ..." message so users immediately know to add the key to their TOML rather than puzzling over jinja's bare "'foo' is undefined" output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wdolinar
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.