feat(Postblock): Make options UI items links if possible#719
Conversation
|
Uhhhhhhh. Is this impossible now? Can you no longer go to a post on a blog given the blog UUID and post ID? |
|
Yeah, it looks to me like you can go to |
|
Shit, really? What happens if you do? (Mainly want to see if it ends up on a Redpop 404 page; if it does, my redirection code handling this is busted but can probably be fixed.) |
|
Oh, I guess that's a silly reason to abandon this; it can just look up the blog name via an API request before navigation. Well, not "just," actually, since we can't access apiFetch from a settings panel. But it's solvable. |
or jquery not being stupid
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
|
Hm. Not sure if:
|
|
I would prefix it with
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
|
Ah, this PR straight-up merge conflicts with #2132, doesn't it. So if I merge this PR, I'll then be immediately deleting some of the code in it in that PR. Fun! |
|
Feel free to bikeshed 03fd22f. |
AprilSylph
left a comment
There was a problem hiding this comment.
After four years in development, hopefully it will have been worth the wait.
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>


User-facing changes
Technical explanation
A map* of post ID -> blog UUID entries is stored as a separate storage entry, rather than migrating the blocked posts list to e.g. an array of
[id, ?uuid]. You could definitely do the latter, but that kind of thing requires a bit of thinking to ensure you correctly migrate old entries and don't have race conditions.*I unapologetically call POJO records "maps." Sue me.
Issues this closes
discussion #402
Testing steps