fix: validate CSS color values in painter feature#2281
Closed
MatrixNeoKozak wants to merge 1 commit into
Closed
Conversation
Repository owner
locked as spam and limited conversation to collaborators
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
painterfeature directly utilizes user-defined color preferences to construct CSSborder-image-sourceproperties without validation. This makes the application susceptible to potential CSS injection if malformed or malicious color strings are injected into the extension storage (e.g., via the import/export functionality). This PR introduces a validation step usingCSS.supports()to ensure only valid CSS color strings are processed and applied to the DOM.