feat: Inform user when Chrome autoupdates#2277
Conversation
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
AprilSylph
left a comment
There was a problem hiding this comment.
Works as described.
I think this isn't the ideal user experience, but it is better than nothing.
(I'm pretty sure the UX I want would require a browser version bump, though, which will make it a hard sell for you!)
|
Actually, there is a version of what I'm thinking of that doesn't require any manifest changes: with some expansion in capabilities of the notifications util, what if we called Can't quite decide if clicking the toast would open this modal, or just refresh instantly, or what, but you get the idea. Something that would actually respect an intentional disabling of the whole extension without being too interruptive. |
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
|
What's the UX you want? Background script that reinjects the content script? Anyway, yeah, probably improvable. My first priority is "starting from the next release, users stop posting about our extension being broken when it's not actually broken;" beyond that I'm flexible. (Yes, kicking old-OS users off the update cycle does qualify for "users post about our extension being broken when it's not actually broken.") |
Description
Resolves #2276:
This shows a modal message if XKit Rewritten stops being able to access
browser.xfunctions, which will occur in Chromium-based browsers if the user disables XKit or (possibly, unconfirmed) if there's an automatic update. Basically #1486 on steroids.If we had a background script, we could try to make this happen only on update, not on disable, but for cross-platform-old-browser compatibility reasons we currently don't, and thus don't have access to the APIs that would let us differentiate.
Screenshots
Testing steps
npm start -- -t=chromium), enable XKit Rewritten, open a (logged-in) Tumblr tab, then disable the extension. Confirm that the referenced info modal appears after a short period. You may note that: