Skip to content

fixes panorama on tagged pages and liked feed#2260

Open
theIncandescentAnteater wants to merge 7 commits into
AprilSylph:masterfrom
theIncandescentAnteater:theIncandescentAnteater/bug/panorama-pages
Open

fixes panorama on tagged pages and liked feed#2260
theIncandescentAnteater wants to merge 7 commits into
AprilSylph:masterfrom
theIncandescentAnteater:theIncandescentAnteater/bug/panorama-pages

Conversation

@theIncandescentAnteater

Copy link
Copy Markdown
Contributor

Description

i believe this fixes #1785. as far as i can see, the extension already works on the community feeds.

the classes on the tagged page differ from the dash, but the liked page doesn't have a main element at all

Before After
image image
image image

Testing steps

  1. Load the modified addon
  2. Go to a tagged page
  3. See the wide post width
  4. Go to a the likes feed
  5. See the wide post width

@marcustyphoon

marcustyphoon commented May 21, 2026

Copy link
Copy Markdown
Collaborator

For clarity, the communities bullet point in the linked issue points specifically to https://www.tumblr.com/communities, the single "community posts" feed that contains posts from all of your communities, and individual community posts viewed alone! Panorama does indeed already work in individual community feeds.

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Setting a maximum post width (maxPostWidthVar) is working here on tagged pages, but not on the liked page!

@theIncandescentAnteater

Copy link
Copy Markdown
Contributor Author

thanks! i wasn't in any communities so i didn't even realize that was it's own feed

the max post width on the communities page is a little weird, but i couldn't figure out a better way. there very well may be one though.

this is what it looks like with a max width less than the full width (the grid column is still max width, so the sidebars are still pushed all the way out).
image

panorama on communities feed (without restrictive max post width)
image

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Hm, yeah, I bet there's a way to adjust the size natively. Tumblr's grid-template-columns value is 556px minmax(280px,360px) before we override it; surely we can make our override the same thing but with maxPostWidthVar inserted?

Comment thread src/features/panorama/index.js Outdated
theIncandescentAnteater and others added 3 commits May 21, 2026 21:26
Co-authored-by: marcustyphoon <marcustyphoon@gmail.com>
…rama-pages' into theIncandescentAnteater/bug/panorama-pages
@theIncandescentAnteater

Copy link
Copy Markdown
Contributor Author

overriding with maxPostWidthVar meant that posts were becoming wider than the screen. i'm sure there's a neat way to do it with a grid, but i just ended up adjusting it to mimic the flex layout of the other feeds.

image

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Hm, would something like grid-template-columns: minmax(556px, var(${maxPostWidthVar})) minmax(280px,360px); work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panorama: Nonfunctional on tagged pages; likes; community posts feed

2 participants