feat(Quote Replies): Option to reply as a reblog#1863
Draft
marcustyphoon wants to merge 30 commits into
Draft
Conversation
This reverts commit 9c5a899.
is this really better though
5765a67 to
9ff82f9
Compare
5ad4f5d to
9502f18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Working proof of concept.
This implements the ability for Quote Replies to—rather than creating a new draft post with the quoted reply—create a draft reblog of the target post with the quoted reply.
Remake of #1542, stacked on #1662. Resolves #1414.
This diff is, like. So bad, man. But I guess that's what happens when you implement:
and
I guess that's 24 test cases. Plus one for "click post note; it's not relevant to you and so there should be no meatball menu item shown", so 25. Good times.
Would you believe that this is after probably a solid workday of trying to factor stuff to be simpler?
Testing steps