feat(Mass Privater): Add mass unprivate functionality#1639
feat(Mass Privater): Add mass unprivate functionality#1639marcustyphoon wants to merge 26 commits into
Conversation
| apiFetch(`/v2/blog/${uuid}/posts/${postData.id}`, { | ||
| method: 'PUT', | ||
| body: { | ||
| ...createEditRequestBody(postData), | ||
| state: 'published' | ||
| } |
There was a problem hiding this comment.
hmmm. the fact that this will only work on NPF/text/answer posts is... concerning.
i feel like we should have a separate "incompatible" count to show to the user, rather than trying to action on them here, knowing that the operation will always fail.
do we have a util for NPF compatibility yet? i feel like we need one.
if a post is stored in blocks format, or the original type is text, or the original type is note, it should be editable via NPF endpoints.
There was a problem hiding this comment.
(And yes we do; it currently returns isBlocksPostFormat || shouldOpenInLegacy === false;).
There was a problem hiding this comment.
Made something. A bit rudimentary, maybe, but I'm not sure how to improve it.
There was a problem hiding this comment.
Maybe it should be a <table>...?
5be6337 to
977a7e7
Compare
b137ae1 to
de25bb3
Compare
|
Today I learned: I have absolutely no idea how to control overflow on a table cell. |
marcustyphoon
changed the title
|
(Don't know why I put this in my review queue when it's still marked as "help wanted".) |
|
Oh, this one. I might just give up on table and switch to |
¯\_(ツ)_/¯ (aside: I guess this could also just be a list of links, with some placeholder text added for the posts without a summary. or... yeah, idk. hm, or should the links be formatted timestamps instead of post ids?) |
maybe? idk |
|
Current look. Suggestions welcome. 
|
This reverts commit 6f46e37.
|
Hmm. You know what, what's wrong with just a scrollable list of clickable post URLs? If the post has a summary, it should have a slug too... |
2 participants
Description
Per a number of user requests, this adds the ability to unprivate posts to Mass Privater, including by tag. There's currently no realistic way to do this without an extension, since you can't find all of your private posts (that contain a certain tag or otherwise) through the Tumblr UI. No, it's not fast, but it's faster than manually scrolling through your archive, that's for sure.
Resolves #1626.
Currently contains the diff of #1610; must be rebased after it is merged (or close it if merged first).Testing steps
Oh boy. Um.