Refactor EPUB generation: modularize code and add image asset support#27
Merged
Merged
Conversation
… audit gaps - Split epub-logic/src/lib.rs (609 lines) into six focused submodules (conversion, html, css, nav, opf, table) so every file is ≤ 300 lines - G1: Block::Image now renders <img src alt title/> and embeds data-URI images in OEBPS/Images/ via base64 decoding (new base64 dep) - G2: Block::Table/TableRow/TableHeader/TableCell now render <table>, <thead>/<tbody>, <tr>, <th colspan rowspan>, <td colspan rowspan> - G3: Inline text content is XML-escaped before HTML wrapping - G4: Link href values are XML-escaped - G5: Section <title> content is XML-escaped - G6/G7: BlockAttrs.text_align and indent produce inline style= attributes on <p> and <h*> elements - G8: TiptapMark::NamedSpanStyle wraps text in <span class="style-..."> - G9: Inline::Text.style_name wraps text in <span class="style-..."> - G10: fo:color, fo:background-color, style:font-name, fo:text-decoration, fo:letter-spacing, fo:font-variant and border/padding properties added to ODF→CSS mapping - G11: metadata.creation_date emitted as <dc:date> in OPF - G12: metadata.description and metadata.subject emitted in OPF - G13: Embedded images listed in OPF manifest under OEBPS/Images/ - G14: 609-line file size violation resolved by submodule split - Section titles extracted from first heading block instead of generic "N" - EpubDocument gains images: Vec<ImageAsset> field; from_tiptap gains images parameter for pre-loaded assets from caller - write_epub_zip writes OEBPS/Images/ directory with embedded image assets - All 4 existing tests pass; cargo clippy -D warnings clean https://claude.ai/code/session_01QXTY8ndVt2UpgKFqcJodX5
Formatting-only changes to satisfy the cargo fmt --all -- --check CI gate. No logic changes. https://claude.ai/code/session_01QXTY8ndVt2UpgKFqcJodX5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the EPUB generation logic in
epub-logicby extracting large monolithic functions into focused modules, and adds support for embedding images decoded from data-URIsrcattributes.Key Changes
Modularized code structure: Split
lib.rsinto focused modules:conversion.rs: TiptapNode-to-Block conversion and data-URI image extractionhtml.rs: Block and inline rendering to XHTML with proper XML escapingcss.rs: CSS generation from styles and fontsopf.rs: OPF 3.0 package document generationnav.rs: EPUB 3 Navigation Document generationtable.rs: Table rendering with header/body separationImage asset support:
ImageAssetstruct to represent decoded images with filename, raw bytes, and media typeextract_images_from_blocks()to walk the block tree and decode base64 data-URI imagesImproved XML/XHTML safety:
escape_xml()function for consistent escaping of text content, attributes, and URLsEnhanced section titles:
extract_section_title()that derives titles from heading blocks when availableMetadata enrichment (G11, G12):
creation_date,description, andsubjectfields in OPF metadataCSS improvements (G10):
style:font-nameas alternate ODF font propertyUpdated exports: Modified
export.rsto pass empty image vector tofrom_tiptap()(pre-loaded images can be added by callers)Implementation Details
stylesandimagesparameters for context-aware outputTableHeadercells) into<thead>with remaining rows in<tbody>BlockAttrs(text alignment, indentation) and applied to block elements<span>elementshttps://claude.ai/code/session_01QXTY8ndVt2UpgKFqcJodX5