Skip to content

bench: run orchestration config#3

Open
antfleet-ops wants to merge 9 commits into
mainfrom
pick/run-orchestration-config
Open

bench: run orchestration config#3
antfleet-ops wants to merge 9 commits into
mainfrom
pick/run-orchestration-config

Conversation

@antfleet-ops

Copy link
Copy Markdown
Contributor

Manual file pick from AISynthetics/synthetic-users — runner, job stores, routing, environment, package, and CI surface.

Source repo: AISynthetics/synthetic-users @ 74774c9a48a7

Files:

  • src/agent/agent-runner.js
  • src/open-world-job-store.js
  • src/run-store.js
  • src/env.js
  • src/engine.js
  • src/intent-router.js
  • package.json
  • .github/workflows/ci.yml
  • .env.example

Generated by manual bench onboarding.

@antfleet-ops antfleet-ops reopened this Jun 8, 2026
@antfleet

antfleet Bot commented Jun 8, 2026

Copy link
Copy Markdown

AntFleet · 1 finding

Both reviewers flagged the items below on the changed files. AntFleet posts only what two independent frontier models agree on.


Maintainability · Low — Redundant recomputation of persona collector pack can cause divergence and unnecessary work
src/agent/agent-runner.js

collectorPack is computed in runSyntheticUserAgentTurn and then recomputed inside composeArtifact with similar inputs. This duplication risks divergence if either call drifts and adds avoidable CPU cost.

Fix: Compute collectorPack once in the caller and pass it as a parameter to composeArtifact. Remove the internal recomputation to keep a single source of truth.

Out-of-hunk patch artifact (model: claude-opus-4-7)

This non-click-to-apply fix is outside the PR diff hunk, so GitHub cannot render it as a suggestion.

--- a/src/agent/agent-runner.js
+++ b/src/agent/agent-runner.js
@@
-  const collectorPack = buildPersonaCollectorPack(persona, context);
-  const artifact = await composeArtifact({ persona, context, transcript });
+  const collectorPack = buildPersonaCollectorPack(persona, context);
+  const artifact = await composeArtifact({ persona, context, transcript, collectorPack });
@@
-async function composeArtifact({ persona, context, transcript }) {
-  const collectorPack = buildPersonaCollectorPack(persona, context);
+async function composeArtifact({ persona, context, transcript, collectorPack }) {
+  collectorPack = collectorPack || buildPersonaCollectorPack(persona, context);

Review 0cae5ebd · claude-opus-4-7 + gpt-5 (unanimous) · 81s · ~$0.40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant