bench: run orchestration config#3
Conversation
AntFleet · 1 findingBoth reviewers flagged the items below on the changed files. AntFleet posts only what two independent frontier models agree on. Maintainability · Low — Redundant recomputation of persona collector pack can cause divergence and unnecessary work
Fix: Compute collectorPack once in the caller and pass it as a parameter to composeArtifact. Remove the internal recomputation to keep a single source of truth. Out-of-hunk patch artifact (model: claude-opus-4-7)This non-click-to-apply fix is outside the PR diff hunk, so GitHub cannot render it as a suggestion. --- a/src/agent/agent-runner.js
+++ b/src/agent/agent-runner.js
@@
- const collectorPack = buildPersonaCollectorPack(persona, context);
- const artifact = await composeArtifact({ persona, context, transcript });
+ const collectorPack = buildPersonaCollectorPack(persona, context);
+ const artifact = await composeArtifact({ persona, context, transcript, collectorPack });
@@
-async function composeArtifact({ persona, context, transcript }) {
- const collectorPack = buildPersonaCollectorPack(persona, context);
+async function composeArtifact({ persona, context, transcript, collectorPack }) {
+ collectorPack = collectorPack || buildPersonaCollectorPack(persona, context);— Review |
Manual file pick from AISynthetics/synthetic-users — runner, job stores, routing, environment, package, and CI surface.
Source repo: AISynthetics/synthetic-users @ 74774c9a48a7
Files:
src/agent/agent-runner.jssrc/open-world-job-store.jssrc/run-store.jssrc/env.jssrc/engine.jssrc/intent-router.jspackage.json.github/workflows/ci.yml.env.exampleGenerated by manual bench onboarding.