Skip to content

Fix link and image rules failing to match due to invalid POSIX regex … #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heshammahamed wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix link and image rules failing to match due to invalid POSIX regex … #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aa5b58
Fix link and image rules failing to match due to invalid POSIX regex …
heshammahamed Jun 1, 2026
06744cc
Fixed link rule to support URLs with parentheses and double-bracket t…
heshammahamed Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions MarkdownTranslator.alusus
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,22 @@ class MarkdownTranslator [RegexType: type] {
else this.output += str;
}
}),
// link with double brackets [[text]](url)
Rule("\\[\\[([^]\n]*)\\]\\]\\(([^ \t\n]+)\\)", closure(args: Array[String]) {
def linkText: String = String("[") + args(1) + String("]");
if this.elementStack.getLength() == 0 this.jumpToLevel(String("p"), 1, false);
def target: CharsPtr = "";
if this.linksInNewTab target = "target=\"_blank\""
if this.onHtmlTag.isNull() {
this.output += String.format("<a href=\"%s\" %s>%s</a>", args(2).buf, target, linkText.buf);
} else {
def str: String = this.onHtmlTag("a", args(2), linkText);
if str != "" this.output += str
else this.output += String.format("<a href=\"%s\" %s>%s</a>", args(2).buf, target, linkText.buf);
}
}),
// link
Rule("\\[([^\n\\x5D]*)\\]\\(([^()\n]+)\\)", closure(args: Array[String]) {
Rule("\\[([^]\n]*)\\]\\(([^ \t\n]+)\\)", closure(args: Array[String]) {
if args(1) == "" args(1) = args(2);
if this.elementStack.getLength() == 0 this.jumpToLevel(String("p"), 1, false);
def target: CharsPtr = "";
Expand All @@ -269,7 +283,7 @@ class MarkdownTranslator [RegexType: type] {
}
}),
// image
Rule("!\\[([^\n\\x5D]*)\\]\\(([^()\n]+)\\)", closure(args: Array[String]) {
Rule("!\\[([^]\n]*)\\]\\(([^()\n]+)\\)", closure(args: Array[String]) {
if this.onHtmlTag.isNull() {
this.output += String.format("<img src=\"%s\" title=\"%s\">", args(2).buf, args(1).buf);
} else {
Expand Down Expand Up @@ -328,7 +342,7 @@ class MarkdownTranslator [RegexType: type] {
}
}),
// all chars
Rule("[^\n*\\\\`!\\x5B]+", closure(args: Array[String]) {
Rule("[^\n*\\\\`![]+", closure(args: Array[String]) {
if this.elementStack.getLength() == 0 this.jumpToLevel(String("p"), 1, false);
this.output += args(0);
}),
Expand Down