Prepare skills for coming code changes - #736
Merged
Merged
Conversation
added 2 commits
September 18, 2026 14:47
The commit-message skill lacked rules for referencing functions and manual section numbers, which are consistently used across Gatekeeper's git history. Update the guidelines in .agents/skills/commit-message/SKILL.md to: 1. Require empty parentheses () after internal and project function names as well as function-like macros. 2. Require manual section numbers in parentheses after standard library functions (e.g. free(3), perror(3)), system calls (e.g. getrandom(2)), commands (e.g. ls(1)), and overview pages (e.g. capabilities(7)). 3. Clarify plain text conventions without Markdown backticks. 4. Detail subsystem prefix categories, subject casing exceptions, and issue reference formulas with real-world examples from the git log.
Gatekeeper follows DPDK's coding style guidelines, which are based on the Linux Kernel coding guidelines and FreeBSD kernel developer's manual style(9). However, agents assisting in the repository lacked explicit instructions and reference documentation on these conventions. Add an agent skill under .agents/skills/coding-style/ that documents the coding style requirements, referencing the official DPDK documentation at https://doc.dpdk.org/guides/contributing/coding_style.html. This skill provides: 1. An agent verification checklist covering indentation (hard tabs), line length limits, comment syntax, include order, and pointer/NULL conventions. 2. Comprehensive rules for C preprocessor directives, variable and structure declarations, function definitions and prototypes, control statements, operators, and casts. 3. Gatekeeper-specific idioms, including G_LOG() logging macros, RTE_BUILD_BUG_ON(), and RTE_VERIFY(). 4. Guidelines for Python (PEP 8) and Meson build files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance commit-message guidelines and add coding-style documentation.