Skip to content

fix(deps): override glob and minimatch to latest majors - #4410

Merged
phlipsterit merged 1 commit into
mainfrom
chore/deps-glob-minimatch-overrides
Nov 16, 2026
Merged

phlipsterit merged 1 commit into
mainfrom
chore/deps-glob-minimatch-overrides

Conversation

@phlipsterit

Copy link
Copy Markdown
Contributor

Description

Updates glob and minimatch to their latest major versions, to make sure we get the latest security fixes. These are only used by dev tooling (lint, tests, Cypress, Percy). None of our direct dependencies allow the new majors yet, so this adds scoped resolutions to package.json, one per version range used in the lockfile. Each override only matches the old range, so it stops applying once a parent raises its own range, and can then be removed.

Package From To Pulled in by
glob 10.4.5 / 10.5.0 / 11.0.2 14.0.6 jest, mocha, cypress-parallel, cacache
minimatch 9.0.x / 10.x 11.0.8 eslint, @eslint/config-array, typescript-eslint, eslint-plugin-sonarjs, glob, @percy/cli-doctor

glob 7 and minimatch 3/5 (used by older eslint plugins, rimraf, stylus etc.) are not affected and are left as is.

Why an override instead of updating our own dependencies

The newest releases of eslint, typescript-eslint, jest, mocha (11, via cypress-parallel) and Percy still require glob ^10/^11 and minimatch ^9/^10, so there is no direct-dependency update that pulls in the new majors.

Breaking changes and why they don't affect us

  • minimatch 11 removes makeRe(), Minimatch#regexp, the AST class, matchOne() and the debug option, and matches some edge cases (trailing / with extglobs) closer to Bash.
  • glob 14 uses minimatch 11, renames some Pattern/Processor internals, and changes how ignore patterns starting with / are resolved.

None of the packages above call the removed APIs. To check the matching behaviour:

  • yarn lint passes, and eslint still applies the config and reports errors in a file with deliberate violations
  • yarn test passes (173 suites, 3696 tests), and jest --listTests still finds all 174 test files
  • yarn tsc passes

This has more surface than the other dependency PRs, so it's worth a closer look in review. Cypress runs in CI will cover cypress-parallel.

Related: #4409 updates lodash and qs in the lockfile.

Related Issue(s)

  • None

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

eslint, typescript-eslint, jest, mocha, cypress-parallel and percy only
allow older glob/minimatch majors.
@phlipsterit phlipsterit added kind/dependencies Pull requests that update a dependency file backport This PR should be cherry-picked onto older release branches labels Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9657076b-13dd-422d-b9d5-0eebb3186ce4
Commits

Reviewing files that changed from the base of the PR and between d2fab2e and 2cf5a0d.

Files ignored due to path filters: 1

  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 1

  • package.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@phlipsterit
phlipsterit marked this pull request as ready for review November 16, 2026 08:27
@phlipsterit phlipsterit added the approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review label Nov 16, 2026
@phlipsterit
phlipsterit merged commit fcd6b4c into main Nov 16, 2026
23 of 24 checks passed
@phlipsterit
phlipsterit deleted the chore/deps-glob-minimatch-overrides branch November 16, 2026 08:49
@github-actions

Copy link
Copy Markdown
Contributor

✅ Automatic backport successful!

A backport PR has been automatically created for the release/v4.37 release branch.

The release branch release/v4.37 already existed and was updated.

The cherry-pick was clean with no conflicts. Please review the backport PR when it appears.

phlipsterit added a commit that referenced this pull request Nov 16, 2026
eslint, typescript-eslint, jest, mocha, cypress-parallel and percy only
allow older glob/minimatch majors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review backport This PR should be cherry-picked onto older release branches kind/dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant