Repository navigation
fix(deps): override glob and minimatch to latest majors - #4410
Merged
Merged
Conversation
eslint, typescript-eslint, jest, mocha, cypress-parallel and percy only allow older glob/minimatch majors.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
phlipsterit
marked this pull request as ready for review
November 16, 2026 08:27
Contributor
|
✅ Automatic backport successful! A backport PR has been automatically created for the The release branch The cherry-pick was clean with no conflicts. Please review the backport PR when it appears. |
phlipsterit
added a commit
that referenced
this pull request
Nov 16, 2026
eslint, typescript-eslint, jest, mocha, cypress-parallel and percy only allow older glob/minimatch majors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
globandminimatchto their latest major versions, to make sure we get the latest security fixes. These are only used by dev tooling (lint, tests, Cypress, Percy). None of our direct dependencies allow the new majors yet, so this adds scopedresolutionstopackage.json, one per version range used in the lockfile. Each override only matches the old range, so it stops applying once a parent raises its own range, and can then be removed.glob 7 and minimatch 3/5 (used by older eslint plugins, rimraf, stylus etc.) are not affected and are left as is.
Why an override instead of updating our own dependencies
The newest releases of eslint, typescript-eslint, jest, mocha (11, via cypress-parallel) and Percy still require glob
^10/^11and minimatch^9/^10, so there is no direct-dependency update that pulls in the new majors.Breaking changes and why they don't affect us
makeRe(),Minimatch#regexp, theASTclass,matchOne()and thedebugoption, and matches some edge cases (trailing/with extglobs) closer to Bash.Pattern/Processorinternals, and changes howignorepatterns starting with/are resolved.None of the packages above call the removed APIs. To check the matching behaviour:
yarn lintpasses, and eslint still applies the config and reports errors in a file with deliberate violationsyarn testpasses (173 suites, 3696 tests), andjest --listTestsstill finds all 174 test filesyarn tscpassesThis has more surface than the other dependency PRs, so it's worth a closer look in review. Cypress runs in CI will cover cypress-parallel.
Related: #4409 updates lodash and qs in the lockfile.
Related Issue(s)
Verification/QA
kind/*andbackport*label to this PR for proper release notes grouping