Skip to content

fix(deps): override basic-ftp and serialize-javascript to latest majors - #4406

Merged
phlipsterit merged 1 commit into
mainfrom
chore/deps-security-resolutions
Nov 16, 2026
Merged

phlipsterit merged 1 commit into
mainfrom
chore/deps-security-resolutions

Conversation

@phlipsterit

@phlipsterit phlipsterit commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Updates two transitive dev dependencies to their latest major versions, to make sure we get the latest security fixes. The parent packages only allow the older major version, so this adds scoped resolutions to package.json. Each override only matches the old range (^5.0.2 / ^6.0.2), so it stops applying once the parents raise their own ranges, and can then be removed.

Package From To Pulled in by
basic-ftp 5.0.5 6.2.6 get-uri ← pac-proxy-agent ← @percy/cli
serialize-javascript 6.0.2 7.1.4 mocha 11 ← cypress-parallel

Why an override instead of updating our own dependencies

Neither package has a release on its old major line with these changes, and updating our direct dependencies doesn't pull in the new majors:

  • basic-ftp comes from @percy/cli and @percy/cypress. Even the latest Percy (1.32.12) and the latest pac-proxy-agent/get-uri still require basic-ftp ^5.
  • serialize-javascript comes from cypress-parallel. Its latest release (0.15.0, March 2025) requires mocha ^11, and every mocha 11 release requires serialize-javascript ^6.

Breaking changes in the new majors, and why they don't affect us:

  • basic-ftp 6.0.0: separate FTP transfer hosts are no longer allowed by default. Percy only reaches basic-ftp for ftp:// PAC URLs, which we don't use.
  • serialize-javascript 7.0.0: requires Node.js 20 or newer. We run Node 24.

Smoke-tested locally: mocha, serialize-javascript, basic-ftp and get-uri all load and work, yarn cypress-parallel --help runs, and yarn tsc passes.

Related: #4405 updates the remaining transitive dependencies in the lockfile.

Related Issue(s)

  • None

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Summary by CodeRabbit

  • Chores
    • Updated internal project configuration. No user-facing changes are included in this update.

@phlipsterit phlipsterit added kind/dependencies Pull requests that update a dependency file backport This PR should be cherry-picked onto older release branches labels Nov 15, 2026
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Yarn resolutions block adds overrides for basic-ftp and serialize-javascript. It retains the existing jsdom resolution.

Changes: Dependency resolutions

Layer / File(s) Summary
Dependency version overrides
package.json
The resolutions block adds overrides for basic-ftp and serialize-javascript. The existing jsdom patch remains.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: olemartinorg

Merge Risk: Minimal · up to 73bc3

This change updates two transitive dev dependencies through scoped overrides. It affects development tooling only, with no production runtime impact. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: scoped dependency overrides that move basic-ftp and serialize-javascript to new major versions. The raw summary confirms package.json adds these resolutions. The title uses…
Description check Passed The description follows the repository template. It has a Description section that explains the overrides, the reasons, and the breaking-change analysis. It has a Related Issue(s) section that states …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: scoped dependency overrides that move basic-ftp and serialize-javascript to new major versions. The raw summary confirms package.json adds these resolutions. The title uses the conventional commit prefix and states the main change, so it passes.

Full details: Description check

Explanation

The description follows the repository template. It has a Description section that explains the overrides, the reasons, and the breaking-change analysis. It has a Related Issue(s) section that states None. It has a Verification/QA checklist with the relevant boxes ticked. The template asks for a non-technical summary for release notes. The description gives a technical summary, so it does not fully meet that request. The related issue field is None, which is acceptable. Overall the description is mostly complete, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55b6c1c1-1ef8-4a25-8407-0c1c09462ad7
Commits

Reviewing files that changed from the base of the PR and between 99b93f2 and 73bc399.

Files ignored due to path filters: 1

  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

get-uri (via @percy/cli) and mocha 11 (via cypress-parallel) only allow
the older major versions.
@phlipsterit
phlipsterit force-pushed the chore/deps-security-resolutions branch from 36d2680 to 73bc399 Compare November 15, 2026 21:27
@phlipsterit phlipsterit changed the title fix(deps): override basic-ftp and serialize-javascript to patched versions fix(deps): override basic-ftp and serialize-javascript to latest majors Nov 15, 2026
@phlipsterit
phlipsterit marked this pull request as ready for review November 16, 2026 07:30
@phlipsterit phlipsterit added the approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review label Nov 16, 2026
@phlipsterit
phlipsterit merged commit d2fab2e into main Nov 16, 2026
19 checks passed
@phlipsterit
phlipsterit deleted the chore/deps-security-resolutions branch November 16, 2026 08:00
@github-actions

Copy link
Copy Markdown
Contributor

✅ Automatic backport successful!

A backport PR has been automatically created for the release/v4.37 release branch.

The release branch release/v4.37 already existed and was updated.

The cherry-pick was clean with no conflicts. Please review the backport PR when it appears.

phlipsterit added a commit that referenced this pull request Nov 16, 2026
…rs (#4406)

get-uri (via @percy/cli) and mocha 11 (via cypress-parallel) only allow
the older major versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review backport This PR should be cherry-picked onto older release branches kind/dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant