Repository navigation
fix(deps): override basic-ftp and serialize-javascript to latest majors - #4406
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
get-uri (via @percy/cli) and mocha 11 (via cypress-parallel) only allow the older major versions.
36d2680 to
73bc399
Compare
|
✅ Automatic backport successful! A backport PR has been automatically created for the The release branch The cherry-pick was clean with no conflicts. Please review the backport PR when it appears. |
…rs (#4406) get-uri (via @percy/cli) and mocha 11 (via cypress-parallel) only allow the older major versions.
Description
Updates two transitive dev dependencies to their latest major versions, to make sure we get the latest security fixes. The parent packages only allow the older major version, so this adds scoped
resolutionstopackage.json. Each override only matches the old range (^5.0.2/^6.0.2), so it stops applying once the parents raise their own ranges, and can then be removed.Why an override instead of updating our own dependencies
Neither package has a release on its old major line with these changes, and updating our direct dependencies doesn't pull in the new majors:
@percy/cliand@percy/cypress. Even the latest Percy (1.32.12) and the latest pac-proxy-agent/get-uri still require basic-ftp^5.cypress-parallel. Its latest release (0.15.0, March 2025) requires mocha^11, and every mocha 11 release requires serialize-javascript^6.Breaking changes in the new majors, and why they don't affect us:
ftp://PAC URLs, which we don't use.Smoke-tested locally:
mocha,serialize-javascript,basic-ftpandget-uriall load and work,yarn cypress-parallel --helpruns, andyarn tscpasses.Related: #4405 updates the remaining transitive dependencies in the lockfile.
Related Issue(s)
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit