Conversation
Move Antalya-only errors to a separate append-only registry with wire codes 10001–10006. Preserve symbolic names and the existing exception packet layout; do not introduce legacy numeric aliases. Store vendor counters compactly and include them in `system.errors`, `system.error_log`, and Prometheus metrics. Skip unnamed accounting slots in the error log to avoid attributing unknown errors to the sentinel. Validate vendor IDs, names, upstream conflicts, and `UInt16` bounds. Preserve the upstream `values` API and name-table construction to reduce forward-porting overhead. Document the numeric migration and add lookup, accounting, log-column, and distributed-forwarding regression tests.
Skip only the shared out-of-range accounting slot in `system.error_log`, rather than every unnamed slot. Upstream gaps retain their actual numeric identities and must continue to be logged. Add regression coverage for codes 779, 780, and 899, retain sentinel suppression tests, and correct the accounting documentation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Antalya-only errors to a separate append-only registry with wire codes 10001–10006. Preserve symbolic names and the existing exception packet layout; do not introduce legacy numeric aliases.
Store vendor counters compactly and include them in
system.errors,system.error_log, and Prometheus metrics. Skip unnamed accounting slots in the error log to avoid attributing unknown errors to the sentinel.Validate vendor IDs, names, upstream conflicts, and
UInt16bounds. Preserve the upstreamvaluesAPI and name-table construction to reduce forward-porting overhead.Document the numeric migration and add lookup, accounting, log-column, and distributed-forwarding regression tests.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Separate Antalya error codes from upstream ones to prevent any collisions in the future
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: