Repository navigation
Antalya 26.8: Allow empty object storage cluster - #2469
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #2221 from Altinity/feature/antalya-26.6/object_storage_cluster_allow_empty Antalya 26.6: Allow empty object storage cluster # Conflicts: # src/Storages/ObjectStorage/StorageObjectStorageCluster.cpp
Took the source PR's `getQueryProcessingStage` body (`resolveClusterRead` + `shouldReadLocallyOnFallbackToPure`). Kept `readsFromPureStorage` from antalya-26.8 since `appliesRowLevelFilterInRead` still uses it.
CI triage — @zvonandVerdict: 0 failures attributable to this PR. The red checks are 1 pre-existing/flaky crash in an unrelated subsystem and 2 base-image vulnerability scans. Every functional check that exercises this PR's code is green (builds on all targets, stateless incl. the new Failure-by-failure1. Stress test (amd_debug) — 1/5 — NOT PR-caused (pre-existing/flaky, unrelated subsystem) This is the PostgreSQL wire-protocol handler trying to serialize an error response onto a connection whose buffer was already canceled (client disconnected mid-query) — a known race that surfaces under stress. It has nothing to do with this PR, which touches only 2 & 3. Grype Scan (keeper: 4 high/critical, server-alpine: 1 high/critical) — NOT PR-caused (base-image CVEs / infra) 4. Health checkThis is a clean backport of #2221 ("Allow empty object storage cluster"). The functionally meaningful signal is all-green: it builds on every target, and the new behavior is directly exercised by both the new stateless test |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow empty object storage cluster (#2221 by @ianton-ru).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #2221.
Rebase of #2028
Documentation entry for user-facing changes
With 'object_storage_cluster' setting query to s3,iceberg and some other sources are executed as cluster request.
But with swarm cluster, when initiator is not a cluster member, may be situation when no one swarm node is alive at the moment. In this case query is failed with
CLUSTER_DOESNT_EXISTerror.New setting
object_storage_cluster_fallback_if_emptyallow to execute read query on local node in this case.Write query is not executed on cluster right now, so attempt to write is still failed in this case to avoid situation when query is success when swarm is empty and failed when has some nodes alive.
PR is a little bit complex because:
s3(...)- can fall back ifobject_storage_clusteris empty (cluster does not have active nodes, not 'empty setting value')s3(...) SETTINGS object_storage_remote_initiator=1- failed on local node ifobject_storage_clusteris emptys3(...) SETTINGS object_storage_remote_initiator=1, object_storage_remote_initiator_cluster='...'- decision about falling back must be made on remote initiator, on local nodeobject_storage_clustercan be unknown.But behavior is not changed for
Clusterfunctions:s3Cluster(...)- can't fall backs3Cluster(...) SETTINGS object_storage_remote_initiator=1- must failed on remote initiator ifobject_storage_clusteris empty.