Skip to content

Antalya 26.8: Antalya 26:6 Multiple fixes for Iceberg operations #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 4 commits into from
Oct 3, 2026
Merged

Antalya 26.8: Antalya 26:6 Multiple fixes for Iceberg operations #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6370bc1
Merge pull request #2157 from Altinity/antalya_26_6_fix_alter_table_i…
mkmkme Aug 20, 2026
8c7fe16
Merge branch 'antalya-26.8' of github.com:Altinity/ClickHouse into fe…
zvonand Oct 2, 2026
a1de0c8
Drop the `Decimal256` leg of `test_writes_decimal_wide_minmax_pruning`
zvonand Oct 2, 2026
cca2ac5
Match new `RestCatalog` conflict log in `test_catalog_commit_conflict…
zvonand Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Common/FailPoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ static struct InitFiu
REGULAR(slowdown_skip_index_read_result_build) \
ONCE(iceberg_writes_cleanup) \
REGULAR(iceberg_slow_manifest_read) \
ONCE(iceberg_alter_catalog_update_schema_fail) \
ONCE(iceberg_alter_catalog_commit_reported_as_failed) \
REGULAR(storage_cluster_read_sleep) \
ONCE(iceberg_writes_non_retry_cleanup) \
ONCE(iceberg_writes_post_publish_throw) \
Expand Down
4 changes: 3 additions & 1 deletion src/Databases/DataLake/GlueCatalog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,9 @@ bool GlueCatalog::updateSchema(
const String & table_name,
const String & new_metadata_path,
Poco::JSON::Object::Ptr new_schema,
Int32 /*previous_schema_id*/) const
Int32 /*previous_schema_id*/,
Int32 /*new_last_column_id*/,
Poco::JSON::Object::Ptr /*metadata*/) const
{
std::vector<Aws::Glue::Model::Column> columns;
if (new_schema)
Expand Down
4 changes: 3 additions & 1 deletion src/Databases/DataLake/GlueCatalog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ class GlueCatalog final : public ICatalog, private DB::WithContext
const String & table_name,
const String & new_metadata_path,
Poco::JSON::Object::Ptr new_schema,
Int32 previous_schema_id) const override;
Int32 previous_schema_id,
Int32 new_last_column_id,
Poco::JSON::Object::Ptr metadata = nullptr) const override;

void dropTable(const String & namespace_name, const String & table_name, bool delete_data) const override;

Expand Down
4 changes: 3 additions & 1 deletion src/Databases/DataLake/ICatalog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,9 @@ bool ICatalog::updateSchema(
const String & /*table_name*/,
const String & /*new_metadata_path*/,
Poco::JSON::Object::Ptr /*new_schema*/,
Int32 /*previous_schema_id*/) const
Int32 /*previous_schema_id*/,
Int32 /*new_last_column_id*/,
Poco::JSON::Object::Ptr /*metadata*/) const
{
throw DB::Exception(DB::ErrorCodes::NOT_IMPLEMENTED, "updateSchema is not implemented");
}
Expand Down
4 changes: 3 additions & 1 deletion src/Databases/DataLake/ICatalog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,9 @@ class ICatalog
const String & table_name,
const String & new_metadata_path,
Poco::JSON::Object::Ptr new_schema,
Int32 previous_schema_id) const;
Int32 previous_schema_id,
Int32 new_last_column_id,
Poco::JSON::Object::Ptr metadata = nullptr) const;

/// Drop table from catalog.
virtual void dropTable(const String & namespace_name, const String & table_name, bool delete_data) const;
Expand Down
Loading
Loading