Skip to content

Small fixes#77

Merged
AlmanaX-21 merged 4 commits into
26.1.2from
small-fixes
Jun 16, 2026
Merged

Small fixes#77
AlmanaX-21 merged 4 commits into
26.1.2from
small-fixes

Conversation

@AlmanaX-21

@AlmanaX-21 AlmanaX-21 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added configurable debug logging that displays detailed diagnostic messages only when debug mode is enabled, reducing log verbosity by default.
  • Changes

    • Updated the Logistics Node Item crafting recipe with new material requirements.
    • Modified round-robin distribution mode behavior for export target rotation.

@AlmanaX-21 AlmanaX-21 self-assigned this Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f342d9f4-32b7-42ba-b1b7-5df258d7a889

📥 Commits

Reviewing files that changed from the base of the PR and between 70384ca and 7333e03.

⛔ Files ignored due to path filters (3)
  • src/generated/server/.cache/e88f6de44d8fc0b9080327bad4cda895a2e9dfa8 is excluded by !**/.cache/**, !**/generated/**
  • src/generated/server/data/logisticsnetworks/advancement/recipes/misc/logistics_node.json is excluded by !**/generated/**
  • src/generated/server/data/logisticsnetworks/recipe/logistics_node.json is excluded by !**/generated/**
📒 Files selected for processing (10)
  • src/main/java/me/almana/logisticsnetworks/client/screen/ComputerScreen.java
  • src/main/java/me/almana/logisticsnetworks/client/theme/ThemeState.java
  • src/main/java/me/almana/logisticsnetworks/data/NetworkRegistry.java
  • src/main/java/me/almana/logisticsnetworks/datagen/ModRecipeProvider.java
  • src/main/java/me/almana/logisticsnetworks/entity/LogisticsNodeEntity.java
  • src/main/java/me/almana/logisticsnetworks/logic/TransferEngine.java
  • src/main/java/me/almana/logisticsnetworks/menu/ComputerMenu.java
  • src/main/java/me/almana/logisticsnetworks/network/ClientPayloadHandler.java
  • src/main/java/me/almana/logisticsnetworks/network/ServerPayloadHandler.java
  • src/main/java/me/almana/logisticsnetworks/upgrade/UpgradeLimitsConfig.java

📝 Walkthrough

Walkthrough

The PR removes round-robin distribution state (roundRobinIndex field and three public methods) from LogisticsNodeEntity and strips the corresponding rotation logic from TransferEngine. Across nine source files, existing log statements are wrapped behind Config.debugMode checks. The logistics node crafting recipe is replaced with new ingredients, and default TierLimits batch values are updated for all tiers.

Changes

Round-Robin State Removal

Layer / File(s) Summary
Remove round-robin state from LogisticsNodeEntity
src/main/java/me/almana/logisticsnetworks/entity/LogisticsNodeEntity.java
Deletes the roundRobinIndex per-channel field and the three public getRoundRobinIndex/advanceRoundRobin methods; gates the kill() warning log behind Config.debugMode.
Remove round-robin rotation from TransferEngine
src/main/java/me/almana/logisticsnetworks/logic/TransferEngine.java
Removes channel-index argument from orderTargets, removes target-count argument from updateBackoff, strips ROUND_ROBIN cursor-advancement from updateBackoff, and replaces the ROUND_ROBIN branch in orderTargets with a no-op returning the original list unchanged.

Config.debugMode Log Gating

Layer / File(s) Summary
Server-side log gating
src/main/java/me/almana/logisticsnetworks/data/NetworkRegistry.java, src/main/java/me/almana/logisticsnetworks/menu/ComputerMenu.java, src/main/java/me/almana/logisticsnetworks/network/ServerPayloadHandler.java
Gates high-load dispatch, processing error, overflow, empty-network deletion, and load-count logs in NetworkRegistry; gates player-UUID and network-count debug logs in ComputerMenu; gates all [LabelSync] debug logs (including a new per-node entry) in ServerPayloadHandler.
Client-side log gating
src/main/java/me/almana/logisticsnetworks/client/screen/ComputerScreen.java, src/main/java/me/almana/logisticsnetworks/client/theme/ThemeState.java, src/main/java/me/almana/logisticsnetworks/network/ClientPayloadHandler.java
Gates IOException warnings in ComputerScreen file operations and receiveNetworkList debug loop; gates load/save/listener exception logs in ThemeState; gates network-count and screen-routing debug logs in ClientPayloadHandler.
TransferEngine voiding logs and UpgradeLimitsConfig load/save logs
src/main/java/me/almana/logisticsnetworks/logic/TransferEngine.java, src/main/java/me/almana/logisticsnetworks/upgrade/UpgradeLimitsConfig.java
Gates item- and fluid-transfer voiding error logs in TransferEngine; gates config-not-found, tier-missing, load-success, parse-failure, generateDefault, and save-failure logs in UpgradeLimitsConfig.

Recipe and Tier Default Changes

Layer / File(s) Summary
Logistics node recipe and default tier limits
src/main/java/me/almana/logisticsnetworks/datagen/ModRecipeProvider.java, src/main/java/me/almana/logisticsnetworks/upgrade/UpgradeLimitsConfig.java
Replaces the shaped recipe for LOGISTICS_NODE_ITEM using deep slate, iron bars, and ender pearl (previously obsidian and ender eye); updates defaultForTier() batch values for tiers 1–4 and the default case.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Almana-mc/LogisticsNetworks#21: Introduced the ComputerScreen GUI and payload flow that this PR modifies by gating its debug logging behind Config.debugMode.

Poem

🐇 Hop hop, the logs go quiet at last,
No more chatter from the rabbit's past!
Round-robin indexes? Gone with a thud,
Pearl replaces eye in the crafting blood.
Debug mode gates what noisy logs say—
A cleaner network to hop through today! 🌿

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch small-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlmanaX-21 AlmanaX-21 merged commit 4fd81ec into 26.1.2 Jun 16, 2026
2 of 3 checks passed
@AlmanaX-21 AlmanaX-21 deleted the small-fixes branch June 16, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant