Skip to content

Slot filter fixes#76

Merged
AlmanaX-21 merged 3 commits into
26.1.2from
slot-filter-fixes
Jun 14, 2026
Merged

Slot filter fixes#76
AlmanaX-21 merged 3 commits into
26.1.2from
slot-filter-fixes

Conversation

@AlmanaX-21

@AlmanaX-21 AlmanaX-21 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Release Notes

  • New Features

    • Added slot numbers overlay feature - press Alt+I to toggle display of slot index numbers on container screens.
    • Enhanced transfer engine with per-target import slot mapping support for improved item distribution control.
  • Documentation

    • Added localization entries for the new slot numbers feature.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 36fb93f6-8491-4b08-980b-966f5d912290

📥 Commits

Reviewing files that changed from the base of the PR and between dbd9f60 and 5e0a35e.

📒 Files selected for processing (7)
  • CHANGELOGS/26.1.2-1.8.1.md
  • src/main/java/me/almana/logisticsnetworks/LogisticsClientEvents.java
  • src/main/java/me/almana/logisticsnetworks/client/SlotNumberOverlay.java
  • src/main/java/me/almana/logisticsnetworks/client/WrenchHudOverlay.java
  • src/main/java/me/almana/logisticsnetworks/logic/FilterLogic.java
  • src/main/java/me/almana/logisticsnetworks/logic/TransferEngine.java
  • src/main/resources/assets/logisticsnetworks/lang/en_us.json

📝 Walkthrough

Walkthrough

Adds a client-side SlotNumberOverlay that toggles slot index rendering on container screens via Alt+I, reusing a now-public LOGISTICS_CATEGORY from WrenchHudOverlay. Separately, TransferEngine gains per-target import slot mapping: ItemTransferTarget records a new hasImportSlotMapping flag, and executeMove computes item-specific allowed-slot masks via a new FilterLogic.hasConfiguredSlotMapping helper.

Changes

Client Slot Number Overlay

Layer / File(s) Summary
SlotNumberOverlay class, wiring, and localization
src/main/java/me/almana/logisticsnetworks/client/WrenchHudOverlay.java, src/main/java/me/almana/logisticsnetworks/client/SlotNumberOverlay.java, src/main/java/me/almana/logisticsnetworks/LogisticsClientEvents.java, src/main/resources/assets/logisticsnetworks/lang/en_us.json, CHANGELOGS/26.1.2-1.8.1.md
WrenchHudOverlay.LOGISTICS_CATEGORY is widened to public; SlotNumberOverlay is added with TOGGLE_SLOT_NUMBERS keybinding (Alt+I), a static toggle flag, key event handlers, and post-render slot index drawing; registration is wired in LogisticsClientEvents; i18n strings and changelog entry are added.

TransferEngine Import Slot Mapping

Layer / File(s) Summary
FilterLogic helper
src/main/java/me/almana/logisticsnetworks/logic/FilterLogic.java
New hasConfiguredSlotMapping method scans a filter ItemStack[] and returns true when any item contains slot-mapping configuration.
TransferEngine import slot mask computation
src/main/java/me/almana/logisticsnetworks/logic/TransferEngine.java
ItemTransferTarget gains a hasImportSlotMapping boolean; target construction derives it from import filters; executeMove computes a per-item importAllowedSlots mask when active and passes it to all insertItemWithAllowedSlots calls; new computeImportAllowedSlots helper builds the mask via FilterLogic.matchesItemInSlot.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 Hop, hop! The slots now show their number true,
Alt+I reveals what's hidden from your view.
The engine maps each slot with careful care,
Import filters route your items with flair.
This rabbit's code is tidy, sharp, and new! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slot-filter-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlmanaX-21 AlmanaX-21 merged commit 72cb345 into 26.1.2 Jun 14, 2026
2 of 3 checks passed
@AlmanaX-21 AlmanaX-21 deleted the slot-filter-fixes branch June 14, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant