Skip to content

feat: E2EE Voice Chat, Screenshare and Camera#143

Open
secp192k1 wants to merge 25 commits into
Aliucord:mainfrom
secp192k1:feat/sunflower
Open

feat: E2EE Voice Chat, Screenshare and Camera#143
secp192k1 wants to merge 25 commits into
Aliucord:mainfrom
secp192k1:feat/sunflower

Conversation

@secp192k1

Copy link
Copy Markdown

@rushiiMachine

Copy link
Copy Markdown
Member

We're not shipping proprietary binaries directly in Manager

@secp192k1

secp192k1 commented Jun 15, 2026

Copy link
Copy Markdown
Author

We're not shipping proprietary binaries directly in Manager

Understandable, however I couldn't implement this in any other feasible way.

I assume that your idea would to host the native libs in aliucord website, just like how the old version of discord is stored. Which well, can't really host it since I dont have access to the website, I'll make a PR on the website repo soon.
Edit: Its on maven repo, cant PR anything lol

Question, if the files do get hosted via the website, should they be cached and should there be a button/method to clear that file cache ln the manager?

@secp192k1

Copy link
Copy Markdown
Author

@rushiiMachine more questions while thinking about this, assuming the libs do get hosted on maven like the old app is..

  1. Should I add an hash check for those library files?
    If yes, would that be stored on maven or on manager?
  2. Should the custom initial core (Aliucord.zip, Injector.dex, etc) also be stored on maven?
  3. The "Clear Cache" button in manager will be wired to also clear all of these new downloaded files, correct?

@Ushie

Ushie commented Jun 15, 2026

Copy link
Copy Markdown
Member

You don't need custom core and custom injector, you can just PR to them

@Ushie

Ushie commented Jun 15, 2026

Copy link
Copy Markdown
Member

Marking as draft until binaries are hosted somewhere

@Ushie Ushie marked this pull request as draft June 15, 2026 11:42
@secp192k1

Copy link
Copy Markdown
Author

The following files in maven need to be updated:

  • Aliucord.zip
  • patches.zip
  • Injector.dex

That were built from Aliucord/Aliucord#752

@rushiiMachine

Copy link
Copy Markdown
Member
  1. Should I add an hash check for those library files?

There is already logic in DownloadDiscordStep to verify signature of APK, you can extend that. I haven't looked at what you did though

  1. Should the custom initial core (Aliucord.zip, Injector.dex, etc) also be stored on maven?

what?

  1. The "Clear Cache" button in manager will be wired to also clear all of these new downloaded files, correct?

If it reuses the same paths obtained from PathManager and follows the same format as DownloadDiscordStep, yes

@secp192k1

This comment was marked as outdated.

@secp192k1 secp192k1 marked this pull request as ready for review June 18, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants