Skip to content

[PWGJE] Remove HfHelper instances - #18437

Merged
vkucera merged 2 commits into
AliceO2Group:masterfrom
vkucera:hf-helper-PWGJE
Oct 23, 2026
Merged

vkucera merged 2 commits into
AliceO2Group:masterfrom
vkucera:hf-helper-PWGJE

Conversation

@vkucera

@vkucera vkucera commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 49 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Remove HfHelper instances [PWGJE] Remove HfHelper instances Oct 23, 2026
nzardosh
nzardosh previously approved these changes Oct 23, 2026
@nzardosh
nzardosh enabled auto-merge (squash) October 23, 2026 13:14
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4c9e9d5 at 2026-10-23 15:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 13 warnings.'
Found 1 errors and 13 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/52870d2953b819196104fd8a658e9bde59880286/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetFinderHFQA.h:19:1: error: included header HfHelper.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/52870d2953b819196104fd8a658e9bde59880286/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetFinderHFQA.h:46:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/jetFinderHFQA.h:98:33: warning: implicit conversion 'double' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/jetFinderHFQA.h:98:33: warning: narrowing conversion from constant 'double' to 'bool' [bugprone-narrowing-conversions]
PWGJE/Tasks/jetFinderHFQA.h:99:32: warning: implicit conversion 'double' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/jetFinderHFQA.h:99:32: warning: narrowing conversion from constant 'double' to 'bool' [bugprone-narrowing-conversions]
PWGJE/Tasks/jetFinderHFQA.h:100:33: warning: implicit conversion 'double' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/jetFinderHFQA.h:100:33: warning: narrowing conversion from constant 'double' to 'bool' [bugprone-narrowing-conversions]
PWGJE/Tasks/jetFinderHFQA.h:101:34: warning: implicit conversion 'double' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/jetFinderHFQA.h:101:34: warning: narrowing conversion from constant 'double' to 'bool' [bugprone-narrowing-conversions]
PWGJE/Tasks/jetFinderHFQA.h:102:34: warning: implicit conversion 'double' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/jetFinderHFQA.h:102:34: warning: narrowing conversion from constant 'double' to 'bool' [bugprone-narrowing-conversions]
PWGJE/Tasks/jetFinderHFQA.h:103:35: warning: implicit conversion 'double' -> 'bool' [readability-implicit-bool-conversion]
PWGJE/Tasks/jetFinderHFQA.h:103:35: warning: narrowing conversion from constant 'double' to 'bool' [bugprone-narrowing-conversions]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera
vkucera disabled auto-merge October 23, 2026 13:35
@vkucera
vkucera merged commit ea9224c into AliceO2Group:master Oct 23, 2026
13 checks passed
@vkucera
vkucera deleted the hf-helper-PWGJE branch October 23, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants