Skip to content

[PWGHF] Add information to get generated signals with daughters in acceptance - #18377

Merged
fgrosa merged 4 commits into
AliceO2Group:masterfrom
fgrosa:xic
Oct 21, 2026
Merged

[PWGHF] Add information to get generated signals with daughters in acceptance#18377
fgrosa merged 4 commits into
AliceO2Group:masterfrom
fgrosa:xic

Conversation

@fgrosa

@fgrosa fgrosa commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Hi @creetz16 this PR adds the information to get the signals with daughters in acceptance, as discussed offline

@github-actions github-actions Bot added the pwghf PWG-HF label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add information to get generated signals with daughters in acceptance [PWGHF] Add information to get generated signals with daughters in acceptance Oct 21, 2026
@alibuild

alibuild commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 220d1f2 at 2026-10-21 17:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:744:40: error: unused parameter 'etaPi0' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:745:40: error: unused parameter 'etaPi1' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:746:40: error: unused parameter 'etaPiBachelor' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:747:40: error: unused parameter 'etaPiFromLambda' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:748:40: error: unused parameter 'etaPrFromLambda' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 220d1f2 at 2026-10-21 17:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:744:40: error: unused parameter 'etaPi0' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:745:40: error: unused parameter 'etaPi1' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:746:40: error: unused parameter 'etaPiBachelor' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:747:40: error: unused parameter 'etaPiFromLambda' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:748:40: error: unused parameter 'etaPrFromLambda' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 220d1f2 at 2026-10-21 18:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 15 errors and 0 warnings.'
Found 15 errors and 0 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/3a1c4b9cd2fc7d941547fa0c5d000b6f8749e7d2/O2Physics-code-check/errors.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:744:40: error: parameter 'etaPi0' is unused [misc-unused-parameters,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:744:40: error: unused parameter 'etaPi0' [clang-diagnostic-unused-parameter,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:745:40: error: parameter 'etaPi1' is unused [misc-unused-parameters,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:745:40: error: unused parameter 'etaPi1' [clang-diagnostic-unused-parameter,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:746:40: error: parameter 'etaPiBachelor' is unused [misc-unused-parameters,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:746:40: error: unused parameter 'etaPiBachelor' [clang-diagnostic-unused-parameter,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:747:40: error: parameter 'etaPiFromLambda' is unused [misc-unused-parameters,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:747:40: error: unused parameter 'etaPiFromLambda' [clang-diagnostic-unused-parameter,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:748:40: error: parameter 'etaPrFromLambda' is unused [misc-unused-parameters,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:748:40: error: unused parameter 'etaPrFromLambda' [clang-diagnostic-unused-parameter,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:750:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:67: error: no header providing "kXiMinus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:78: error: no header providing "kPiPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:763:68: error: no header providing "kLambda0" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:769:74: error: no header providing "kProton" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 15 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6470112 at 2026-10-21 19:48:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/e962d4b67ad20f5f7d79e0b42f3ef79a2de2f9ff/O2Physics-code-check/errors.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:750:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:67: error: no header providing "kXiMinus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:78: error: no header providing "kPiPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:765:68: error: no header providing "kLambda0" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:772:74: error: no header providing "kProton" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@fgrosa
fgrosa enabled auto-merge (squash) October 21, 2026 18:04
alibuild
alibuild approved these changes Oct 21, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@alibuild

alibuild commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4c5ce1e at 2026-10-21 20:12:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 1 warnings.'
Found 5 errors and 1 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/573a6aacd8d933552519667c3f5fdab032d0f710/O2Physics-code-check/errors.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:750:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:73: error: no header providing "kXiMinus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:84: error: no header providing "kPiPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:766:76: error: no header providing "kLambda0" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:774:86: error: no header providing "kProton" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/573a6aacd8d933552519667c3f5fdab032d0f710/O2Physics-code-check/warnings.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:420:327: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

@fgrosa Please fix the headers before merging.

@fgrosa
fgrosa merged commit ae803ec into AliceO2Group:master Oct 21, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgrosa @alibuild @vkucera