[PWGHF] Add more input features for Xic0 KF selection by Rrantu · Pull Request #18349 · AliceO2Group/O2Physics

Rrantu · 2026-10-19T08:27:25Z

Extend the Xic0 to Xi π KF ML response to support the 28 input features used by the local PbPb Transformer model.

github-actions · 2026-10-19T08:27:42Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

vkucera · 2026-10-19T08:36:31Z

Hi @Rrantu , please fix the errors and warnings.

alibuild · 2026-10-19T08:42:59Z

Error while checking build/O2Physics/code-check for 56de32c at 2026-10-19 10:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 10 warnings.'
Found 2 errors and 10 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/03c4998581075c3577c443f6db343fd5d45378fb/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:25:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/03c4998581075c3577c443f6db343fd5d45378fb/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:38:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:40:32: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:45:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:51:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_VALUE' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:57:9: warning: function-like macro 'FILL_MAP_XIC0TOXIPIKF_AS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:81:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:86:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:147:41: warning: initializer for member 'outputMlXic0ToXiPi' is redundant [readability-redundant-member-init]
PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:123:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-10-19T11:39:39Z

Error while checking build/O2Physics/code-check for d97bf67 at 2026-10-19 13:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 10 warnings.'
Found 2 errors and 10 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/aa6dea4bf80a10bb41d003a6a9d47ff0dc742ebf/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:25:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/aa6dea4bf80a10bb41d003a6a9d47ff0dc742ebf/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:38:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:40:32: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:45:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:51:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_VALUE' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:57:9: warning: function-like macro 'FILL_MAP_XIC0TOXIPIKF_AS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:81:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:86:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:147:41: warning: initializer for member 'outputMlXic0ToXiPi' is redundant [readability-redundant-member-init]
PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:123:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

vkucera · 2026-10-19T13:20:24Z

There is still a warning from O2 linter.

Rrantu · 2026-10-19T15:00:13Z

There is still a warning from O2 linter.

Hi @vkucera , it seems that I can’t resolve these two warnings within this PR, as both would require changes to the upstream workflow or repository settings.

alibuild · 2026-10-19T15:03:56Z

Error while checking build/O2Physics/code-check for 821e08a at 2026-10-19 17:03:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 10 warnings.'
Found 2 errors and 10 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/fae358b79a1e92c29af0e2a67674d052590f5abf/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:25:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/fae358b79a1e92c29af0e2a67674d052590f5abf/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:38:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:40:32: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:45:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:51:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_VALUE' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:57:9: warning: function-like macro 'FILL_MAP_XIC0TOXIPIKF_AS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:81:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:86:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorToXiPiQa.cxx:147:41: warning: initializer for member 'outputMlXic0ToXiPi' is redundant [readability-redundant-member-init]
PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:123:52: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:56: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-10-19T15:05:34Z

Error while checking build/O2Physics/o2 for 4b5a28f at 2026-10-19 17:05:

No log files found

Full log here.

alibuild · 2026-10-19T15:08:02Z

Error while checking build/O2Physics/code-check for 4b5a28f at 2026-10-20 18:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 4 warnings.'
Found 1 errors and 4 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/9a680f797ad95ec5dd8b8415957be1f1a6020bd8/O2Physics-code-check/errors.txt
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/9a680f797ad95ec5dd8b8415957be1f1a6020bd8/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:38:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:45:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:51:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_VALUE' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:57:9: warning: function-like macro 'FILL_MAP_XIC0TOXIPIKF_AS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

vkucera · 2026-10-19T15:30:14Z

There is still a warning from O2 linter.

Hi @vkucera , it seems that I can’t resolve these two warnings within this PR, as both would require changes to the upstream workflow or repository settings.

Hi @Rrantu , thanks for the effort but I was referring to the O2 linter warning. I assume you tried to fix the code check warnings instead.

Rrantu · 2026-10-20T10:15:01Z

There is still a warning from O2 linter.

Hi @vkucera , it seems that I can’t resolve these two warnings within this PR, as both would require changes to the upstream workflow or repository settings.

Hi @Rrantu , thanks for the effort but I was referring to the O2 linter warning. I assume you tried to fix the code check warnings instead.

Hi @vkucera , the O2 linter warning seems to be related to .github/workflows/o2-linter.yml and Node.js 20. I’m not sure if there’s anything I can do on my side to address it.

vkucera · 2026-10-20T13:57:58Z

There is still a warning from O2 linter.

Hi @vkucera , it seems that I can’t resolve these two warnings within this PR, as both would require changes to the upstream workflow or repository settings.

Hi @Rrantu , thanks for the effort but I was referring to the O2 linter warning. I assume you tried to fix the code check warnings instead.

Hi @vkucera , the O2 linter warning seems to be related to .github/workflows/o2-linter.yml and Node.js 20. I’m not sure if there’s anything I can do on my side to address it.

That is not an O2 linter warning. The linter log is always in the "Run tests" step. The linter cannot analyse the namesInputFeatures configurable because you declare the variable and the JSON name on different lines.

vkucera · 2026-10-20T13:58:57Z


 #include <cstdint>
-#include <vector>
+#include <vector> // IWYU pragma: keep


Please do not add the pragma. This is a temporary issue that I should be able to fix soon.

Rrantu · 2026-10-20T16:25:35Z

There is still a warning from O2 linter.

Hi @vkucera , it seems that I can’t resolve these two warnings within this PR, as both would require changes to the upstream workflow or repository settings.

Hi @Rrantu , thanks for the effort but I was referring to the O2 linter warning. I assume you tried to fix the code check warnings instead.

Hi @vkucera , the O2 linter warning seems to be related to .github/workflows/o2-linter.yml and Node.js 20. I’m not sure if there’s anything I can do on my side to address it.

That is not an O2 linter warning. The linter log is always in the "Run tests" step. The linter cannot analyse the namesInputFeatures configurable because you declare the variable and the JSON name on different lines.

Thanks a lot! I've fixed this.

alibuild · 2026-10-20T16:57:10Z

Error while checking build/O2Physics/code-check for 8814094 at 2026-10-20 18:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 4 warnings.'
Found 2 errors and 4 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/fec55c82f8a2bda5e7b33c8e655cf397fb8d1df2/O2Physics-code-check/errors.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:25:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/fec55c82f8a2bda5e7b33c8e655cf397fb8d1df2/O2Physics-code-check/warnings.txt
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:38:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_FULL' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:45:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:51:9: warning: function-like macro 'CHECK_AND_FILL_VEC_XIC0TOXIPIKF_VALUE' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
PWGHF/Core/HfMlResponseXic0ToXiPiKf.h:57:9: warning: function-like macro 'FILL_MAP_XIC0TOXIPIKF_AS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Rrantu added 2 commits October 18, 2026 22:50

add features

1c8c633

remove useless info

56de32c

Rrantu requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, singhra1994, stefanopolitano, vkucera, xinyepeng and zhangbiao-phy as code owners October 19, 2026 08:27

github-actions Bot added the pwghf PWG-HF label Oct 19, 2026

github-actions Bot changed the title ~~Add more input features for Xic0 KF selection~~ [PWGHF] Add more input features for Xic0 KF selection Oct 19, 2026

fix bug

821e08a

fix error

d97bf67

fix errors

4b5a28f

vkucera reviewed Oct 20, 2026

View reviewed changes

fix O2 linter warning

8814094

Conversation

Rrantu commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Oct 19, 2026

Uh oh!

alibuild commented Oct 19, 2026

Uh oh!

alibuild commented Oct 19, 2026

Uh oh!

vkucera commented Oct 19, 2026

Uh oh!

Rrantu commented Oct 19, 2026

Uh oh!

alibuild commented Oct 19, 2026

Uh oh!

alibuild commented Oct 19, 2026

Uh oh!

alibuild commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Oct 19, 2026

Uh oh!

Rrantu commented Oct 20, 2026

Uh oh!

vkucera commented Oct 20, 2026

Uh oh!

vkucera Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Rrantu commented Oct 20, 2026

Uh oh!

alibuild commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 19, 2026 •

edited

Loading

alibuild commented Oct 19, 2026 •

edited

Loading