Skip to content

Fix race conditions while distributing ACTIVE stattus #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Oct 20, 2026
Merged

Fix race conditions while distributing ACTIVE stattus #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions core/environment/transition_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,13 @@ func (t DeployTransition) do(env *Environment) (err error) {

return*/

notifyStatus := make(chan task.Status)
// notifyStatusCh is used only as a wake-up signal. To be sure that updates are not missed we need to
// query the status wia wf.GetStatus() because senders is sending asynchronously so the value
// inside the channel does not have to be the most recent. I didn't change the channel type to
// not break something else.
notifyStatusCh := make(chan task.Status, 1)
subscriptionId := uuid.NewUUID().String()
env.wfAdapter.SubscribeToStatusChange(subscriptionId, notifyStatus)
env.wfAdapter.SubscribeToStatusChange(subscriptionId, notifyStatusCh)
defer env.wfAdapter.UnsubscribeFromStatusChange(subscriptionId)

// listen to workflow State changes
Expand Down Expand Up @@ -230,7 +234,8 @@ func (t DeployTransition) do(env *Environment) (err error) {
WORKFLOW_ACTIVE_LOOP:
for {
select {
case wfStatus = <-notifyStatus:
case <-notifyStatusCh:
wfStatus = wf.GetStatus()
log.WithField("status", wfStatus.String()).
WithField("partition", env.Id().String()).
Debug("workflow status change")
Expand Down Expand Up @@ -268,6 +273,10 @@ func (t DeployTransition) do(env *Environment) (err error) {

case <-time.After(deploymentTimeout):
wfStatus = wf.GetStatus()
// just a safety check in case we missed the final update
if wfStatus == task.ACTIVE {
break WORKFLOW_ACTIVE_LOOP
}
inactiveTaskRoles := make([]string, 0)
undeployableTaskRoles := make([]string, 0)
workflow.LeafWalk(wf, func(role workflow.Role) {
Expand Down
Loading