Skip to content

[O2B-1630] Fix issue where in embeded profiles, some logs properties were not returned - #2250

Merged
graduta merged 2 commits into
mainfrom
bug/O2B-1630/embded-logs-profile-to-display-information
Oct 19, 2026
Merged

graduta merged 2 commits into
mainfrom
bug/O2B-1630/embded-logs-profile-to-display-information

Conversation

@graduta

@graduta graduta commented Oct 19, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • In sub-views of log-overview table, some of the properties were not loaded. e.g. run-details page would not display the environments, datapasses, lhc fills associated to logs

Notable changes for developers:

  • Code reusability has been improved

Changes made to the database:

@graduta
graduta requested a balanced review from Copilot October 19, 2026 09:04
@graduta graduta self-assigned this Oct 19, 2026
@graduta
graduta requested a review from isaachilly as a code owner October 19, 2026 09:04
@graduta graduta added bug Something isn't working backend labels Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.35%. Comparing base (795e8c6) to head (4982fc9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
- Coverage   46.37%   46.35%   -0.03%     
==========================================
  Files        1047     1047              
  Lines       17271    17268       -3     
  Branches     3143     3140       -3     
==========================================
- Hits         8010     8004       -6     
- Misses       9261     9264       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Run-linked logs lose tag colors and archived styling through the shared query’s restricted tag projection.

1 open issue
What changed in this PR

Restores missing log relations in embedded tables by reusing shared retrieval logic.

Changes:

  • Routes run-linked log retrieval through LogService.
  • Includes attachments in shared log queries.
  • Adds regression tests for embedded-table relations.
File Description
test/​lib/​server/​services/​log/​LogService.test.js Tests run relations and linked-log attachments.
test/​api/​tags.test.js Tests tag-linked log relations.
test/​api/​runs.test.js Checks embedded run-log relations.
test/​api/​lhcFills.test.js Checks fill-linked log relations.
test/​api/​environments.test.js Checks environment-linked log relations.
lib/​usecases/​run/​GetLogsByRunUseCase.js Delegates retrieval to LogService.
lib/​server/​services/​log/​LogService.js Adds run retrieval and attachment loading.
lib/​database/​repositories/​LogRepository.js Removes superseded run-log query.

Review effort: Balanced

Comment thread lib/server/services/log/LogService.js Outdated
@graduta
graduta merged commit 7df2a7b into main Oct 19, 2026
25 checks passed
@graduta
graduta deleted the bug/O2B-1630/embded-logs-profile-to-display-information branch October 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants