Repository navigation
Conversation
The TRK configuration file (TRKBase.configFile) accepts an optional 8th column, rInnRow, which chooses the staves of a staggered layer (layers 3 and 4) that sit at rInn: 0 = even staves (default, previous behaviour), 1 = odd staves, i.e. stave 0 in the shifted row. Existing files and the default layouts give the same geometry as before. A value other than 0 or 1 is fatal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lorber98
marked this pull request as ready for review
October 21, 2026 07:31
lorber98
marked this pull request as draft
October 21, 2026 15:31
The TRK configuration file (TRKBase.configFile) accepts an optional 9th column, phiOffset (degrees, counterclockwise as phi), which rotates all the staves of a ML layer about the beam axis, keeping their tilt. Existing files and the default layouts give the same geometry as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lorber98
marked this pull request as ready for review
October 21, 2026 21:00
njacazio
approved these changes
Oct 22, 2026
njacazio
enabled auto-merge (squash)
October 22, 2026 02:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TRK configuration file (
TRKBase.configFile, layoutskSegmentedandkSimplifiedRealistic) accepts two new optional columns for the ML layers:8th column,
rInnRow: in the staggered layers (3 and 4) it chooses which staves sit atrInn:0: even staves atrInn(default, current behaviour);1: odd staves atrInn, i.e. stave 0 in the shifted row.In the flipped layer 3 the
rInnrow is the outer one and the shift points inwards, so thererInnRow = 1puts stave 0 in the inner row; in layer 4 in the outer row.9th column,
phiOffset(degrees, counterclockwise as phi, default 0): rotates all the staves of a ML layer about the beam axis. They keep their tilt with respect to their own radial directions.The columns are positional: to give
rInnRowthe mode column (7th) must be written too, to givephiOffsetalsorInnRow.rInnRowother than 0 or 1 is fatal. Non-default values are reported in the log, e.g.Layer 3 (staggered): even staves in the inner row (rInnRow = 1)(or as having no effect on a layer that is not staggered).Why
To reproduce in O2, with the native TRK builder, the layout of the current CAD model of the middle layers:
rInnRowthe native layer 3 always has stave 0 in therInnrow (the outer one, since the layer is flipped);Configuration file with the CAD layout
Parameters derived from the silicon of the CAD staves (latest model). Columns must be separated by TABs. Usage:
--configKeyValues "TRKBase.layoutMLOT=kSegmented;TRKBase.configFile=<file>"With this file every stave of the five ML layers has the same phi, tilt and row as the CAD stave.